public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hong Xu <hong.xu@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3 v2] ARM: ARM1136 - Remove flush_cache from arch/arm/lib/cache.c
Date: Fri, 19 Aug 2011 17:59:16 +0800	[thread overview]
Message-ID: <4E4E33F4.9040005@atmel.com> (raw)
In-Reply-To: <201108191140.47097.marek.vasut@gmail.com>

Hi Marek,

On 08/19/2011 05:40 PM, Marek Vasut wrote:
> On Friday, August 19, 2011 11:23:14 AM Hong Xu wrote:
>> arch/arm/lib/cache.c is cleaned and no real cache operation will be
>> defined in this file. A new file arch/arm/cpu/arm1136/cache.c is
>> created. This file will define the real cache operations.
>>
>> Signed-off-by: Hong Xu<hong.xu@atmel.com>
>> Tested-by: Elen Song<elen.song@atmel.com>
>> CC: Albert Aribaud<albert.u.boot@aribaud.net>
>> ---
>> Since V2
>>      Removed redundant ifdef for CONFIG_OMAP2420 || CONFIG_ARM1136
>>
>>   arch/arm/cpu/arm1136/Makefile |    2 +-
>>   arch/arm/cpu/arm1136/cache.c  |   31 +++++++++++++++++++++++++++++++
>>   2 files changed, 32 insertions(+), 1 deletions(-)
>>   create mode 100644 arch/arm/cpu/arm1136/cache.c
>>
>> diff --git a/arch/arm/cpu/arm1136/Makefile b/arch/arm/cpu/arm1136/Makefile
>> index 930e0d1..5b5f330 100644
>> --- a/arch/arm/cpu/arm1136/Makefile
>> +++ b/arch/arm/cpu/arm1136/Makefile

[...]

>> + */
>> +
>> +#include<common.h>
>> +
>> +void flush_cache(unsigned long start, unsigned long size)
>> +{
>> +	void arm1136_cache_flush(void);
>
> Whoa this void on the left side is strange ;-)

Just copied from original file. ;-)

Move it out and change to "extern void arm1136_cache_flush(void);", OK 
for you?

BR,
Eric

>
>> +
>> +	arm1136_cache_flush();
>> +}

  reply	other threads:[~2011-08-19  9:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19  9:23 [U-Boot] [PATCH 1/3 v2] ARM: Clean arch/arm/lib/cache.c Hong Xu
2011-08-19  9:23 ` [U-Boot] [PATCH 2/3 v2] ARM: ARM1136 - Remove flush_cache from arch/arm/lib/cache.c Hong Xu
2011-08-19  9:40   ` Marek Vasut
2011-08-19  9:59     ` Hong Xu [this message]
2011-08-19 12:57       ` Marek Vasut
2011-10-06 21:50   ` Wolfgang Denk
2011-08-19  9:23 ` [U-Boot] [PATCH 3/3 v2] ARM: ARM926EJS - Add cache operations Hong Xu
2011-08-19  9:37   ` Aneesh V
2011-08-19  9:46     ` Marek Vasut
2011-08-19 10:43       ` Aneesh V
2011-08-19 12:55         ` Marek Vasut
2011-08-19 14:16           ` Aneesh V
2011-08-28 19:16             ` Marek Vasut
2011-08-19  9:41   ` Marek Vasut
2011-08-19 10:17   ` Lei Wen
2011-08-19 10:30     ` Hong Xu
2011-08-19 10:31   ` Lei Wen
2011-08-22  2:03     ` Hong Xu
2011-08-19 14:20   ` Aneesh V
2011-08-22  2:14     ` Hong Xu
2011-08-22  3:31       ` V, Aneesh
2011-08-19  9:38 ` [U-Boot] [PATCH 1/3 v2] ARM: Clean arch/arm/lib/cache.c Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4E33F4.9040005@atmel.com \
    --to=hong.xu@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox