From: Aneesh V <aneesh@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3 v2] ARM: ARM926EJS - Add cache operations
Date: Fri, 19 Aug 2011 16:13:30 +0530 [thread overview]
Message-ID: <4E4E3E52.1050900@ti.com> (raw)
In-Reply-To: <201108191146.22942.marek.vasut@gmail.com>
Hi Marek,
On Friday 19 August 2011 03:16 PM, Marek Vasut wrote:
> On Friday, August 19, 2011 11:37:29 AM Aneesh V wrote:
>> Hi Hong,
>>
>> On Friday 19 August 2011 02:53 PM, Hong Xu wrote:
>>> Add a new file arch/arm/cpu/arm926ejs/cache.c and put cache operations
>>> into this file.
>>
>> How about converting as much as possible of these to armv5/armv6 generic
>> code as I mentioned in this thread:
>>
>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/105385/focus=105526
>>
>> On a quick look everything below except the "flush_dcache_all()" seems
>> to be armv5 generic.
>
> I'd be _VERY_ careful here. And this "seems" doesn't sound very convincing. Are
> you dead sure it won't break any v5 CPU we support?
>
What Hong has used is operations mentioned in the ARMv5 architecture
and these are not marked as IMPLEMENTATION DEFINED. So, compliant
implementations should implement those CP15 operations. They may
enhance the operations by adding their own like ARM926EJS seems to be
doing with 'flush d-cache all'.
However, I think that's immaterial. Hong can provide this as a library
and define a CONFIG_* flag to enable it. Let the platform maintainers
decide whether to use it or not. IMHO, it will definitely be an
improvement over what we have today.
best regards,
Aneesh
next prev parent reply other threads:[~2011-08-19 10:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 9:23 [U-Boot] [PATCH 1/3 v2] ARM: Clean arch/arm/lib/cache.c Hong Xu
2011-08-19 9:23 ` [U-Boot] [PATCH 2/3 v2] ARM: ARM1136 - Remove flush_cache from arch/arm/lib/cache.c Hong Xu
2011-08-19 9:40 ` Marek Vasut
2011-08-19 9:59 ` Hong Xu
2011-08-19 12:57 ` Marek Vasut
2011-10-06 21:50 ` Wolfgang Denk
2011-08-19 9:23 ` [U-Boot] [PATCH 3/3 v2] ARM: ARM926EJS - Add cache operations Hong Xu
2011-08-19 9:37 ` Aneesh V
2011-08-19 9:46 ` Marek Vasut
2011-08-19 10:43 ` Aneesh V [this message]
2011-08-19 12:55 ` Marek Vasut
2011-08-19 14:16 ` Aneesh V
2011-08-28 19:16 ` Marek Vasut
2011-08-19 9:41 ` Marek Vasut
2011-08-19 10:17 ` Lei Wen
2011-08-19 10:30 ` Hong Xu
2011-08-19 10:31 ` Lei Wen
2011-08-22 2:03 ` Hong Xu
2011-08-19 14:20 ` Aneesh V
2011-08-22 2:14 ` Hong Xu
2011-08-22 3:31 ` V, Aneesh
2011-08-19 9:38 ` [U-Boot] [PATCH 1/3 v2] ARM: Clean arch/arm/lib/cache.c Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2011-08-11 2:53 [U-Boot] [PATCH 3/3 v2] ARM: ARM926EJS - Add cache operations Hong Xu
2011-08-18 19:56 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4E3E52.1050900@ti.com \
--to=aneesh@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox