[U-Boot] [PATCH 2/3 v2] ARM: ARM1136 - Remove flush_cache from arch/arm/lib/cache.c

Marek Vasut
2011-08-19T12:57:38Z

On Friday, August 19, 2011 11:59:16 AM Hong Xu wrote:
> Hi Marek,
>
> On 08/19/2011 05:40 PM, Marek Vasut wrote:
> > On Friday, August 19, 2011 11:23:14 AM Hong Xu wrote:
> >> arch/arm/lib/cache.c is cleaned and no real cache operation will be
> >> defined in this file. A new file arch/arm/cpu/arm1136/cache.c is
> >> created. This file will define the real cache operations.
> >>
> >> Signed-off-by: Hong Xu<hong.xu@atmel.com>
> >> Tested-by: Elen Song<elen.song@atmel.com>
> >> CC: Albert Aribaud<albert.u.boot@aribaud.net>
> >> ---
> >> Since V2
> >>
> >> Removed redundant ifdef for CONFIG_OMAP2420 || CONFIG_ARM1136
> >>
> >> arch/arm/cpu/arm1136/Makefile | 2 +-
> >> arch/arm/cpu/arm1136/cache.c | 31 +++++++++++++++++++++++++++++++
> >> 2 files changed, 32 insertions(+), 1 deletions(-)
> >> create mode 100644 arch/arm/cpu/arm1136/cache.c
> >>
> >> diff --git a/arch/arm/cpu/arm1136/Makefile
> >> b/arch/arm/cpu/arm1136/Makefile index 930e0d1..5b5f330 100644
> >> --- a/arch/arm/cpu/arm1136/Makefile
> >> +++ b/arch/arm/cpu/arm1136/Makefile
>
> [...]
>
> >> + */
> >> +
> >> +#include<common.h>
> >> +
> >> +void flush_cache(unsigned long start, unsigned long size)
> >> +{
> >> + void arm1136_cache_flush(void);
> >
> > Whoa this void on the left side is strange ;-)
>
> Just copied from original file. ;-)
>
> Move it out and change to "extern void arm1136_cache_flush(void);", OK
> for you?

No externs please. I'd just pull it from start.S into the cache.c.
>
> BR,
> Eric
>
> >> +
> >> + arm1136_cache_flush();
> >> +}