From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] NAND: Really ignore bad blocks when scrubbing
Date: Fri, 19 Aug 2011 15:08:33 -0500 [thread overview]
Message-ID: <4E4EC2C1.6070506@freescale.com> (raw)
In-Reply-To: <1313514195-27345-1-git-send-email-marek.vasut@gmail.com>
On 08/16/2011 12:03 PM, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> drivers/mtd/nand/nand_base.c | 2 +-
> drivers/mtd/nand/nand_util.c | 1 +
> include/linux/mtd/mtd.h | 1 +
> 3 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index a5f872e..3093067 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2224,7 +2224,7 @@ int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr,
> /*
> * heck if we have a bad block, we do not erase bad blocks !
> */
> - if (nand_block_checkbad(mtd, ((loff_t) page) <<
> + if (!instr->scrub && nand_block_checkbad(mtd, ((loff_t) page) <<
> chip->page_shift, 0, allowbbt)) {
> printk(KERN_WARNING "nand_erase: attempt to erase a "
> "bad block at page 0x%08x\n", page);
Changelog should describe why the existing mechanism of overriding the
block_bad method is insufficient (I think there may be issues if you try
to scrub before the bbt is first built) -- and if this supersedes that
mechanism, that mechanism should be removed.
-Scott
next prev parent reply other threads:[~2011-08-19 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 17:03 [U-Boot] [PATCH] NAND: Really ignore bad blocks when scrubbing Marek Vasut
2011-08-19 20:08 ` Scott Wood [this message]
2011-08-19 21:47 ` Marek Vasut
2011-08-19 21:55 ` Scott Wood
2011-08-19 22:46 ` Marek Vasut
2011-08-19 21:57 ` [U-Boot] nested defines coding style Jeroen Hofstee
2011-08-19 22:31 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4EC2C1.6070506@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox