public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mkimage: Fix 'Unknown OMAP image type - 5'
Date: Sat, 20 Aug 2011 17:32:09 +0200	[thread overview]
Message-ID: <4E4FD379.50901@aribaud.net> (raw)
In-Reply-To: <1312912377-12652-1-git-send-email-dirk.behme@gmail.com>

Hi dirk,

Le 09/08/2011 19:52, Dirk Behme a ?crit :
> From: Dirk Behme<dirk.behme@googlemail.com>
>
> Using mkimage with e.g.
>
> tools/mkimage -A arm -T firmware -O u-boot -d u-boot.bin foo.img
>
> gives a warning
>
> "Unknown OMAP image type - 5"
>
> while it seems that the image itself is created successfully.
>
> This does come from the patch "mkimage: Add OMAP boot image support".
>
> The method check_image_type in image_type_params is supposed to just
> return success or failure.  However, for omap it also calls fprintf:
>
> static int omapimage_check_image_types(uint8_t type)
> {
> 	if (type == IH_TYPE_OMAPIMAGE)
> 		return EXIT_SUCCESS;
> 	else {
> 		fprintf(stderr, "Unknown OMAP image type - %x", type);
> 		return EXIT_FAILURE;
> 	}
> }
>
> All the other image checkers and no others have this, so the fix is to
> simply remove the fprintf.
>
> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
> CC: John Rigby<john.rigby@linaro.org>
> CC: Aneesh V<aneesh@ti.com>
> CC: Sandeep Paulraj<s-paulraj@ti.com>
>
> ---

Applied to u-boot-arm/master with Sandeep's agreement, thanks!

Amicalement,
-- 
Albert.

      reply	other threads:[~2011-08-20 15:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 17:52 [U-Boot] [PATCH v2] mkimage: Fix 'Unknown OMAP image type - 5' Dirk Behme
2011-08-20 15:32 ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4FD379.50901@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox