From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Sat, 20 Aug 2011 17:32:09 +0200
Subject: [U-Boot] [PATCH v2] mkimage: Fix 'Unknown OMAP image type - 5'
In-Reply-To: <1312912377-12652-1-git-send-email-dirk.behme@gmail.com>
References: <1312912377-12652-1-git-send-email-dirk.behme@gmail.com>
Message-ID: <4E4FD379.50901@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi dirk,

Le 09/08/2011 19:52, Dirk Behme a ?crit :
> From: Dirk Behme<dirk.behme@googlemail.com>
>
> Using mkimage with e.g.
>
> tools/mkimage -A arm -T firmware -O u-boot -d u-boot.bin foo.img
>
> gives a warning
>
> "Unknown OMAP image type - 5"
>
> while it seems that the image itself is created successfully.
>
> This does come from the patch "mkimage: Add OMAP boot image support".
>
> The method check_image_type in image_type_params is supposed to just
> return success or failure.  However, for omap it also calls fprintf:
>
> static int omapimage_check_image_types(uint8_t type)
> {
> 	if (type == IH_TYPE_OMAPIMAGE)
> 		return EXIT_SUCCESS;
> 	else {
> 		fprintf(stderr, "Unknown OMAP image type - %x", type);
> 		return EXIT_FAILURE;
> 	}
> }
>
> All the other image checkers and no others have this, so the fix is to
> simply remove the fprintf.
>
> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
> CC: John Rigby<john.rigby@linaro.org>
> CC: Aneesh V<aneesh@ti.com>
> CC: Sandeep Paulraj<s-paulraj@ti.com>
>
> ---

Applied to u-boot-arm/master with Sandeep's agreement, thanks!

Amicalement,
-- 
Albert.