From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Mon, 22 Aug 2011 14:05:23 +0400
Subject: [U-Boot] [PATCH V2 1/2] net/eth.c: throw BUG for
	eth_get_dev_by_name(NULL)
In-Reply-To: <1314002733-17408-1-git-send-email-helmut.raiger@hale.at>
References: <m2wrfmv1wq.fsf@ohwell.denx.de>
	<1314002733-17408-1-git-send-email-helmut.raiger@hale.at>
Message-ID: <4E5229E3.6020704@mvista.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello.

On 22-08-2011 12:45, Helmut Raiger wrote:

> eth_get_dev_by_name() is not safe to use for devname being NULL
> as it uses strcmp. This patch makes it fail with a BUG().

> Signed-off-by: Helmut Raiger<helmut.raiger@hale.at>
> ---
> V2: use BUG_ON() instead of gracefully returning 0

>   net/eth.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)

> diff --git a/net/eth.c b/net/eth.c
> index 6523834..25c147c 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -107,6 +107,8 @@ struct eth_device *eth_get_dev_by_name(const char *devname)
>   {
>   	struct eth_device *dev, *target_dev;
>
> +	BUG_ON(devname == 0);

    Do not use 0 instead of NULL.

WBR, Sergei