public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/14] MX5: efikamx: make use of GPIO framework
Date: Mon, 22 Aug 2011 13:15:52 +0200	[thread overview]
Message-ID: <4E523A68.6020302@denx.de> (raw)
In-Reply-To: <201108211354.18969.marek.vasut@gmail.com>

On 08/21/2011 01:54 PM, Marek Vasut wrote:
> On Sunday, August 21, 2011 12:28:22 PM Stefano Babic wrote:
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> CC: Marek Vasut <marek.vasut@gmail.com>
>> ---

Hi Marek,

>> +	gpio_direction_output(IOMUX_TO_GPIO(MX51_PIN_CSI1_HSYNC), 0);
> 
> I'd be careful about the LEDs here.

Well, I have seen the LEDs were not explicitely initialized. Maybe it
relies on the default value of the DR register, that should be zero.

> Anyway, I'll try to test it sometimes soon 
> (begining of next week is ok?).

Of course, yes. Thanks for testing !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2011-08-22 11:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-21 10:28 [U-Boot] [PATCH 01/14] IMX: uniform GPIO interface using GPIO framework Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 02/14] MX25: make use of GPIO framework for MX25 processor Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 03/14] MX31: make use of GPIO framework for MX31 processor Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 04/14] MX5: make use of GPIO framework for MX5 processor Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 05/14] MX35: make use of GPIO framework for MX35 processor Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 06/14] MX31: QONG: make use of GPIO framework Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 07/14] MX5: efikamx: " Stefano Babic
2011-08-21 11:54   ` Marek Vasut
2011-08-22 11:15     ` Stefano Babic [this message]
2011-08-22 12:28       ` Marek Vasut
2011-08-21 10:28 ` [U-Boot] [PATCH 08/14] MX25: zmx25: " Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 09/14] MX5: mx53ard: " Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 10/14] MX5: mx53smd: " Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 11/14] MX5: vision2: " Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 12/14] MX5: mx53evk: " Stefano Babic
2011-08-21 12:24   ` Jason Liu
2011-08-21 10:28 ` [U-Boot] [PATCH 13/14] MX5: mx53loco: " Stefano Babic
2011-08-22  2:54   ` Jason Liu
2011-08-22  7:57     ` Stefano Babic
2011-08-21 10:28 ` [U-Boot] [PATCH 14/14] MX35: mx35pdk: " Stefano Babic
2011-08-21 16:37 ` [U-Boot] [PATCH 01/14] IMX: uniform GPIO interface using " Fabio Estevam
2011-08-22  7:54   ` Stefano Babic
2011-08-22  7:55 ` [U-Boot] [PATCH 15/15] MX5: mx51evk: make use of " Stefano Babic
2011-08-26 10:10 ` [U-Boot] [PATCH 16/17] MX31: mx31ads: " Stefano Babic
2011-08-26 10:10 ` [U-Boot] [PATCH 17/17] MX31: imx31_litekit: " Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E523A68.6020302@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox