From mboxrd@z Thu Jan  1 00:00:00 1970
From: Helmut Raiger <helmut.raiger@hale.at>
Date: Mon, 22 Aug 2011 17:00:15 +0200
Subject: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver
	available
In-Reply-To: <201108221600.39161.marek.vasut@gmail.com>
References: <1314020497-30897-1-git-send-email-helmut.raiger@hale.at>
	<1314020497-30897-2-git-send-email-helmut.raiger@hale.at>
	<201108221600.39161.marek.vasut@gmail.com>
Message-ID: <4E526EFF.50509@hale.at>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/22/2011 04:00 PM, Marek Vasut wrote:
> +	u32 pdr0 = __REG(CCM_PDR0);
> Can't we do readl() here?
>
>> +
>> +	/* divided by HSP_PODF in PDR0 */
>> +	freq /= ((pdr0>>  11)&  0x7) + 1;
> Um, don't we have defined constants for those magic numbers already?
Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the 
code, which was in the file. The generic.c file for MX35 however is a 
different story.

To keep things simple, I suggest we leave it at that for now.

Helmut





--
Scanned by MailScanner.