From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helmut Raiger Date: Mon, 22 Aug 2011 17:51:05 +0200 Subject: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available In-Reply-To: <201108221702.47352.marek.vasut@gmail.com> References: <1314020497-30897-1-git-send-email-helmut.raiger@hale.at> <201108221600.39161.marek.vasut@gmail.com> <4E526EFF.50509@hale.at> <201108221702.47352.marek.vasut@gmail.com> Message-ID: <4E527AE9.4040409@hale.at> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/22/2011 05:02 PM, Marek Vasut wrote: > >> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the >> code, which was in the file. The generic.c file for MX35 however is a >> different story. >> >> To keep things simple, I suggest we leave it at that for now. > And noone's gonna fix it later. No please, define the proper constants please. > Do you really expect me to fix code in all the arch/arm/cpu/arm1136/mx31 files (2000+ lines) that use that kind of access, because I add 15 lines to one of them? There are some 50 other drivers and boards etc. that depend on imx-regs.h, which probably use these access methods as-well! I'm not prepared to take this effort, sorry. After all this is _COSMETIC_, while this new mx3fb driver really works nicely ;-) If anyone out there modifies these files, I'll definitely rebase the driver to it. Helmut -- Scanned by MailScanner.