[U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

[Stefano Babic <sbabic@denx.de>]

On 08/22/2011 05:51 PM, Helmut Raiger wrote:
> On 08/22/2011 05:02 PM, Marek Vasut wrote:
>>
>>> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the
>>> code, which was in the file. The generic.c file for MX35 however is a
>>> different story.
>>>
>>> To keep things simple, I suggest we leave it at that for now.
>> And noone's gonna fix it later. No please, define the proper constants please.
>>

Hi Helmut,

> Do you really expect me to fix code in all the arch/arm/cpu/arm1136/mx31 
> files (2000+ lines) that use that kind of access, because I add 15 lines 
> to one of them? 

No, nobody thinks you should do this. However, should be not better to
fix it for the 15 lines of code you added ?

Agree that a lot of things in imx-regs.h for i.MX31 are missing. The
i.MX31 was the first i.MX processor added to u-boot, and there are still
some parts that are different from the rest of IMX code.

However, can you add a simple macro to get the HSP_PODF field ? I agree
it does not change the behavior, but it helps a bit to understand the
code without running to the i.MX31 manual...

Macro to set the PODR register are already defined in imx-regs.h. As you
pointed out, there is no macro to get values from the register.

>There are some 50 other drivers and boards etc. that 
> depend on imx-regs.h, which probably use these access methods as-well!

Yes, I know. I am trying to uniform the behavior between i.MX processors.

> I'm not prepared to take this effort, sorry.

Do not do it, it is not asked. We make always a step-by-step approach.
Add defines only for the part you added (as I can see, it is only
related to get the HSP_PODF field in podr register), and let the rest of
the 2000+ lines untouched.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================