From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graeme Russ Date: Wed, 24 Aug 2011 22:56:33 +1000 Subject: [U-Boot] [RFC] New init sequence processing without init_sequence array In-Reply-To: <20110824124951.3FA2C11F9E75@gemini.denx.de> References: <1313587343-3693-1-git-send-email-graeme.russ@gmail.com> <20110822201023.0F8A111EF9D9@gemini.denx.de> <20110823114920.AD2ED201520@gemini.denx.de> <20110824053849.2317F11F9E75@gemini.denx.de> <20110824064819.0529D11F9E76@gemini.denx.de> <20110824124951.3FA2C11F9E75@gemini.denx.de> Message-ID: <4E54F501.6050706@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, On 24/08/11 22:49, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message you wrote: >> >>> Agreed. I should have written: I have a _readable_ source file that >>> can be parsed without additional tools. >> >> I would hardly call 'grep' an extra tool - How many programmers do you >> know that have never used grep? > > That's not the point. There is a significant difference between seeng > the source code in your favorite editor or in the source code window > of your debugger's GUI or even some IDE, versus having to run > additional commands in a separate window. > >> And by defining #DEBUG I can have a parallel list of function names so when >> the loop picks up the next funtion pointer, it picks up the name as well >> ready to examine before stepping in - OK, not ideal, but still, I think >> the flexibility to seamlessly inject init functions at the board level >> outweighs this > > Sorry, but when reading the source code or when revioewing patches I > cannot paick up any next funtion pointers, I'm stuck with reading the > source code only. Well, I guess I had a good shot at creating a 'better' init sequence - one where any board, SoC, or arch can seamlessly inject a custom init step without treading on any toes. I must say, it was rather fun learning how to build the macros and get the linker to do the right thing and have it all work so quickly. I'll stick it in my bag of tricks for another day :) Regards, Graeme