public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca.ceresoli@comelit.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/9] OMAP3: DIG297: Use generic MMC driver
Date: Wed, 24 Aug 2011 15:43:31 +0200	[thread overview]
Message-ID: <4E550003.4060005@comelit.it> (raw)
In-Reply-To: <1314051236-21740-3-git-send-email-trini@ti.com>

Tom Rini wrote:
> Switch from the legacy omap3 mmc driver to the new generic omap hsmmc
> driver.  This patch is based on the work done for Beagle, etc.
>
> Signed-off-by: Tom Rini<trini@ti.com>

Again, please Cc: the board maintainers in the future, thanks.

> ---
>   board/comelit/dig297/dig297.c |    9 +++++++++
>   include/configs/dig297.h      |    5 +++--
>   2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/board/comelit/dig297/dig297.c b/board/comelit/dig297/dig297.c
> index 0062f12..a7071cd 100644
> --- a/board/comelit/dig297/dig297.c
> +++ b/board/comelit/dig297/dig297.c
> @@ -37,6 +37,7 @@
>   #include<netdev.h>
>   #include<twl4030.h>
>   #include<asm/io.h>
> +#include<asm/arch/mmc_host_def.h>
>   #include<asm/arch/omap3-regs.h>
>   #include<asm/arch/mux.h>
>   #include<asm/arch/mem.h>
> @@ -145,6 +146,14 @@ void set_muxconf_regs(void)
>   	MUX_DIG297();
>   }
>
> +#ifdef CONFIG_GENERIC_MMC
> +int board_mmc_init(bd_t *bis)
> +{
> +	omap_mmc_init(0);
> +	return 0;
> +}
> +#endif
> +
>   #ifdef CONFIG_CMD_NET
>   /*
>    * Routine: setup_net_chip
> diff --git a/include/configs/dig297.h b/include/configs/dig297.h
> index b68f073..0e05df3 100644
> --- a/include/configs/dig297.h
> +++ b/include/configs/dig297.h
> @@ -97,8 +97,9 @@
>   #define CONFIG_BAUDRATE			115200
>   #define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,\
>   					115200}
> -#define CONFIG_MMC
> -#define CONFIG_OMAP3_MMC
> +#define CONFIG_GENERIC_MMC		1
> +#define CONFIG_MMC			1
> +#define CONFIG_OMAP_HSMMC		1

IIRC the coding style says you should define the y/n constants without
a value, e.g.:
   #define CONFIG_GENERIC_MMC
not:
   #define CONFIG_GENERIC_MMC 1

Apart for this:
Tested-by: Luca Ceresoli <luca.ceresoli@comelit.it>

Luca

  reply	other threads:[~2011-08-24 13:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 22:13 [U-Boot] [PATCH 0/9] Use generic MMC driver on remaining OMAP platforms Tom Rini
2011-08-22 22:13 ` [U-Boot] [PATCH 1/9] OMAP3: CM-T35: Use generic MMC driver Tom Rini
2011-08-24 12:31   ` Igor Grinberg
2011-08-24 15:53     ` Tom Rini
2011-08-22 22:13 ` [U-Boot] [PATCH 2/9] OMAP3: DIG297: " Tom Rini
2011-08-24 13:43   ` Luca Ceresoli [this message]
2011-08-24 15:44     ` Tom Rini
2011-08-25 15:06   ` [U-Boot] [PATCH] " Tom Rini
2011-08-22 22:13 ` [U-Boot] [PATCH 3/9] OMAP3: Zoom1: " Tom Rini
2011-08-22 22:13 ` [U-Boot] [PATCH 4/9] OMAP3: Zoom2: " Tom Rini
2011-08-22 22:13 ` [U-Boot] [PATCH 5/9] OMAP3: pandora: " Tom Rini
2011-08-22 22:13 ` [U-Boot] [PATCH 6/9] AM3517 CraneBoard: " Tom Rini
2011-08-22 22:13 ` [U-Boot] [PATCH 7/9] TI OMAP3 SDP3430: " Tom Rini
2011-08-22 22:13 ` [U-Boot] [PATCH 8/9] devkit8000: " Tom Rini
2011-08-22 22:13 ` [U-Boot] [PATCH 9/9] OMAP3: Remove legacy mmc driver Tom Rini
2011-08-30  4:59   ` Premi, Sanjeev
2011-08-30  7:19     ` Marek Vasut
2011-09-03 20:32       ` Andy Fleming
2011-09-07  1:39       ` Rini, Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E550003.4060005@comelit.it \
    --to=luca.ceresoli@comelit.it \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox