From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Wed, 24 Aug 2011 17:45:13 +0200
Subject: [U-Boot] [PATCH 2/2] mx3fb: move to CONFIG_VIDEO
	to	support	videomodes
In-Reply-To: <4E5519FD.1030209@hale.at>
References: <1314020497-30897-1-git-send-email-helmut.raiger@hale.at>	<1314020497-30897-3-git-send-email-helmut.raiger@hale.at>	<4E528E38.9080505@denx.de>	<4E54E638.8000502@hale.at>
	<4E5519FD.1030209@hale.at>
Message-ID: <4E551C89.6050109@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/24/2011 05:34 PM, Helmut Raiger wrote:
> 
> I just found that the mx3fb driver uses:
> 
> static inline u32 reg_read(unsigned long reg)
> {
>         return __REG(reg);
> }
> 
> static inline void reg_write(u32 value, unsigned long reg)
> {
>         __REG(reg) = value;
> }
> 

i.MX31 is quite old, and it was pushed before general ARM accessors were
introduced in u-boot. This is the reason. I appreciate you will fix this
point.

> I am about to change this to readl() and writel(), should I do it in a 
> separate 'cosmetic only' patch before the really thing?
> As it is more or less a re-write anyway (350 of 900 lines changed), it 
> think its probably ok to do it in one shot.

IMHO you can do in one shot - you can mention this change in the commit
message.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================