From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h
Date: Thu, 25 Aug 2011 09:06:22 +0200 [thread overview]
Message-ID: <4E55F46E.6010604@denx.de> (raw)
In-Reply-To: <CADyx3a0pYfW9Ee0kC0h6OQOGtFAd5ceviJvUv9ufSPaRTeOmxw@mail.gmail.com>
On 08/25/2011 08:29 AM, Faisal H wrote:
> While building with omap3_beagle_config configuration,
> getting an error about not finding asm/arch/gpio.h (which does not exist).
> Found that header files are moved to arch/arm/include/asm/arch-.
"make <board>_config" sets a link for asm/arch to
arch/arm/include/asm/arch-. The file is not moved.
Then in my understanding asm/arch/gpio.h is included in asm/gpio.h, and
must not be included directly. Have I missed something ?
> Fixed the includes to find the file..
>
> Signed-off-by: Faisal Hassan<faah87@gmail.com>
> Cc: Wolfgang Denk<wd@denx.de>
>
>
> --- a/board/cm-bf537e/gpio_cfi_flash.c
> +++ b/board/cm-bf537e/gpio_cfi_flash.c
> @@ -8,7 +8,7 @@
>
> #include<common.h>
> #include<asm/blackfin.h>
> -#include<asm/gpio.h>
> +#include<asm/mach-bf537/gpio.h>
However, asm/gpio.h is the correct general interface. The specific part
for the microprocessor is included with #include <asm/arch/gpio.h> in
asm/gpio.h.
You should not need to change it if the links are correctly set. If not,
it is another bug.
> #include<asm/blackfin.h>
> -#include<asm/gpio.h>
> +#include<asm/mach-bf548/gpio.h>
IMHO this change is wrong, and it is correct how it is done currently.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-08-25 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E55EA38.2020808@globaledgesoft.com>
2011-08-25 6:29 ` [U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h Faisal H
2011-08-25 6:59 ` Wolfgang Denk
2011-08-25 7:06 ` Stefano Babic [this message]
2011-08-25 14:06 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E55F46E.6010604@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox