From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 25 Aug 2011 09:06:22 +0200 Subject: [U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h In-Reply-To: References: <4E55EA38.2020808@globaledgesoft.com> Message-ID: <4E55F46E.6010604@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/25/2011 08:29 AM, Faisal H wrote: > While building with omap3_beagle_config configuration, > getting an error about not finding asm/arch/gpio.h (which does not exist). > Found that header files are moved to arch/arm/include/asm/arch-. "make _config" sets a link for asm/arch to arch/arm/include/asm/arch-. The file is not moved. Then in my understanding asm/arch/gpio.h is included in asm/gpio.h, and must not be included directly. Have I missed something ? > Fixed the includes to find the file.. > > Signed-off-by: Faisal Hassan > Cc: Wolfgang Denk > > > --- a/board/cm-bf537e/gpio_cfi_flash.c > +++ b/board/cm-bf537e/gpio_cfi_flash.c > @@ -8,7 +8,7 @@ > > #include > #include > -#include > +#include However, asm/gpio.h is the correct general interface. The specific part for the microprocessor is included with #include in asm/gpio.h. You should not need to change it if the links are correctly set. If not, it is another bug. > #include > -#include > +#include IMHO this change is wrong, and it is correct how it is done currently. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================