From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Thu, 25 Aug 2011 09:25:32 +0200 Subject: [U-Boot] mii_phy.h Message-ID: <4E55F8EC.50001@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Can someone clear me purpose of mii_phy.h? It looks like that it is really ancient file which hasn't been touched from 2003. It is use for two files [monstr at monstr u-boot]$ grep -rn "mii_phy.h" * board/ep8260/mii_phy.c:2:#include board/rpxsuper/mii_phy.c:2:#include + different numbers of arguments against new "version" [monstr at monstr u-boot]$ grep -rn "mii_discover_phy" * arch/m68k/include/asm/fec.h:359:int mii_discover_phy(struct eth_device *dev); arch/powerpc/cpu/mpc8xx/fec.c:63:static int mii_discover_phy(struct eth_device *dev); arch/powerpc/cpu/mpc8xx/fec.c:728: efis->actual_phy_addr = mii_discover_phy (dev); arch/powerpc/cpu/mpc8xx/fec.c:872:static int mii_discover_phy(struct eth_device *dev) arch/powerpc/cpu/mpc85xx/ether_fcc.c:237: mii_discover_phy(); arch/powerpc/cpu/mpc8260/ether_fcc.c:234: mii_discover_phy(); board/ep8260/mii_phy.c:10:mii_discover_phy(void) board/rpxsuper/mii_phy.c:10:mii_discover_phy(void) drivers/net/mcfmii.c:150:int mii_discover_phy(struct eth_device *dev) drivers/net/mcfmii.c:253: info->phy_addr = mii_discover_phy(dev); include/mii_phy.h:4:void mii_discover_phy(void); + that functions without arg are not called either arch/powerpc/cpu/mpc85xx/ether_fcc.c:237: mii_discover_phy(); arch/powerpc/cpu/mpc8260/ether_fcc.c:234: mii_discover_phy(); I found that Frank Panno is ep8260 maintainer. Any comment? The best will be to remove mii_phy entirely. Wolfgang: What do you think? Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian