From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] Global Data: Flagify have_console and env_valid
Date: Sat, 27 Aug 2011 08:36:49 +1000 [thread overview]
Message-ID: <4E582001.3000205@gmail.com> (raw)
In-Reply-To: <201108261615.35642.vapier@gentoo.org>
Hi Mike,
On 27/08/11 06:15, Mike Frysinger wrote:
> looks sane enough to me
>
> when changing the global_data structure, do we need to bump the u-boot
> standalone API number (XF_VERSION in exports.h) ? and i vaguely recall global
> data being passed to like Linux for some arches ? although looking at the
> number of #ifdef's in there, maybe that's already been a long lost battle.
That's a very interesting point. As far as I can tell, XF_VERSION needs to
be incremented when either the global data data structure is modified, or
if functions are added to or removed from the export list. Commit
3469424cb6d939c7aedf1e0efdec44a797c0a18c seems to confirm this:
Note that the location of the standalone application jump table pointer
in the global data structure is affected by this change, breaking
execution of standalone applications compiled for previous versions of
U-Boot.
So I think your point about the #ifdef's in global data is very
interesting. There are a _lot_ of board level defines (LCD, PCI, POST etc)
Question for Wolfgang I think :)
Regards,
Graeme
next prev parent reply other threads:[~2011-08-26 22:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 13:23 [U-Boot] [PATCH] Global Data: Flagify have_console and env_valid Graeme Russ
2011-08-26 13:36 ` [U-Boot] [PATCH V2] " Graeme Russ
2011-08-26 20:15 ` Mike Frysinger
2011-08-26 22:36 ` Graeme Russ [this message]
2011-08-29 18:47 ` Scott Wood
2011-10-06 21:48 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E582001.3000205@gmail.com \
--to=graeme.russ@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox