From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Eric_B=E9nard?= <eric@eukrea.com>
Date: Sat, 27 Aug 2011 15:51:12 +0200
Subject: [U-Boot] [PATCH] beagleboard: enable HUB power on all variants
 of the BeagleBoard
In-Reply-To: <CAD=GYpa_NkphKVz=X-c+Vh2KfnW6rJGtmJghLxpTpRX6nZsOHg@mail.gmail.com>
References: <1314226061-6933-1-git-send-email-agnel.joel@gmail.com>
	<9c84f85dcba04a05bf02cd937fa69bf3@DFLE70.ent.ti.com>
	<CAD=GYpbtJ9Hmjy-XdAHK6XmZTbj3PWnes9ZZpOROuiuKPyiFaA@mail.gmail.com>
	<CAD=GYpa_NkphKVz=X-c+Vh2KfnW6rJGtmJghLxpTpRX6nZsOHg@mail.gmail.com>
Message-ID: <4E58F650.9020408@eukrea.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Joel,

Le 27/08/2011 06:46, Joel A Fernandes a ?crit :
>> The logic is wrong here.  I don't remember the polarity, but I do remember that it is
>> xM-A and xM-B that are the oddballs.  I believe this is the correct change:
>
> Hi Jason,
>
> LEDAON should be high for HUB power up on xMA and xMB, so in your code snip:
>
>>
>> +       switch (get_board_revision()) {
>> +       case REVISION_XM_A:
>> +       case REVISION_XM_B:
>> +               twl4030_led_init(TWL4030_LED_LEDEN_LEDBON);
>
> So this should be TWL4030_LED_LEDEN_LEDBON | TWL4030_LED_LEDEN_LEDAON
>
>> +               break;
>> +       default:
>> +               twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
>
> and, this should be TWL4030_LED_LEDEN_LEDBON
>
> Am I correct?
>
LEDA & LEDB are active low Open Drain outputs so enabling LEDAON bit in LEDEN 
means LEDA output is at low level.

Eric