From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 29 Aug 2011 07:49:37 +0200 Subject: [U-Boot] [PATCH 1/8] net: emaclite: Change driver name and add address In-Reply-To: <201108261524.20308.vapier@gentoo.org> References: <1314362843-18214-1-git-send-email-monstr@monstr.eu> <201108261524.20308.vapier@gentoo.org> Message-ID: <4E5B2871.9000801@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike Frysinger wrote: > On Friday, August 26, 2011 08:47:16 Michal Simek wrote: >> - sprintf(dev->name, "Xilinx_Emaclite"); >> + sprintf(dev->name, "Xelite.%x", base_addr); > > you calculated this down to the byte huh ;). i see it uses the full 16. Yes, I had to because eth_device has 16 chars array for it. > > do we have to worry about people who specify the device in their envs ? i'm > guessing not if the current driver only supports one instance. The whole point is to support several instances that's why I need to add base address to name and fit to 16 chars. Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian