From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/8] net: emaclite: Free allocated space for device
Date: Mon, 29 Aug 2011 07:50:32 +0200 [thread overview]
Message-ID: <4E5B28A8.9070201@monstr.eu> (raw)
In-Reply-To: <201108261525.11054.vapier@gentoo.org>
Mike Frysinger wrote:
> On Friday, August 26, 2011 08:47:22 Michal Simek wrote:
>> --- a/drivers/net/xilinx_emaclite.c
>> +++ b/drivers/net/xilinx_emaclite.c
>> @@ -356,8 +356,10 @@ int xilinx_emaclite_initialize (bd_t *bis, int
>> base_addr) return -1;
>>
>> emaclite = calloc(1, sizeof(struct xemaclite));
>> - if (emaclite == NULL)
>> + if (emaclite == NULL) {
>> + free(dev);
>> return -1;
>> + }
>
> since this bug was introduced by your patch 5/8, please squash it into that
> rather than sending out a known buggy one
aah. Good point.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
next prev parent reply other threads:[~2011-08-29 5:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 12:47 [U-Boot] [PATCH 1/8] net: emaclite: Change driver name and add address Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 2/8] net: emaclite: Remove deviceid property Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 3/8] net: emaclite: Use calloc instead of malloc Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 4/8] net: emaclite: Remove baseaddress from xemaclite Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 5/8] net: emaclite: Use dynamic allocation Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 6/8] net: emaclite: Setup RX/TX ping pong for every instance Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 7/8] net: emaclite: Free allocated space for device Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 8/8] net: emaclite: Move RX/TX ping pong initialization to board Michal Simek
2011-08-26 19:25 ` [U-Boot] [PATCH 7/8] net: emaclite: Free allocated space for device Mike Frysinger
2011-08-29 5:50 ` Michal Simek [this message]
2011-08-26 19:22 ` [U-Boot] [PATCH 5/8] net: emaclite: Use dynamic allocation Mike Frysinger
2011-09-07 20:26 ` [U-Boot] [PATCH 4/8] net: emaclite: Remove baseaddress from xemaclite Wolfgang Denk
2011-08-26 19:24 ` [U-Boot] [PATCH 1/8] net: emaclite: Change driver name and add address Mike Frysinger
2011-08-29 5:49 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5B28A8.9070201@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox