From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 29 Aug 2011 17:03:31 -0500 Subject: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers In-Reply-To: References: <1313745913-28672-1-git-send-email-l.majewski@samsung.com> <201108231732.39791.vapier@gentoo.org> <20110823224246.7F11411F9E62@gemini.denx.de> <201108232301.01270.vapier@gentoo.org> <20110824120744.097ba2c5@lmajewski.digital.local> <20110824132553.A5F2C11F9E76@gemini.denx.de> <20110824181252.CAB9E11F9E76@gemini.denx.de> <20110824211812.1e9f039c@mig> <4E5BFADE.9000200@freescale.com> <4E5C033C.9090808@freescale.com> Message-ID: <4E5C0CB3.6050201@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/29/2011 04:54 PM, Anton Staaf wrote: > On Mon, Aug 29, 2011 at 2:23 PM, Scott Wood wrote: >> With the version in that patch I get the slightly different "error: >> initializer element is not computable at load time". Seems like whether >> you cast the address to (type *) or (void *) determines which error you >> get. This is with GCC 4.5.1 (powerpc) and 4.6.0 (x86). Maybe it's >> arch-dependent, based on available relocation types. >> >> Also, shouldn't the array be of type "char" rather than "char *"? > > Yes, you are correct, it should be a char. That may be the problem. It didn't make a difference. >> How do you make the declaration static? > > you can't with this version of the macro. Are there cases where you > need the buffer to be static? I think you'd want it to be static more often than not. -Scott