From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 30 Aug 2011 11:30:16 +0200 Subject: [U-Boot] [PATCH] Makefile: remove tx25 exception In-Reply-To: <20110829195941.63A4918C46F9@gemini.denx.de> References: <1314629830-32588-1-git-send-email-sbabic@denx.de> <20110829195941.63A4918C46F9@gemini.denx.de> Message-ID: <4E5CADA8.1030006@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/29/2011 09:59 PM, Wolfgang Denk wrote: > Dear Stefano Babic, > > In message <1314629830-32588-1-git-send-email-sbabic@denx.de> you wrote: >> An entry in the main Makefile for the tx25 board is not >> necessary, and the board is added to boards.cfg as all >> other targets. > > In theorey you are right, but this patch appears to be wrong: > >> -tx25_config : unconfig >> - @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk >> - @$(MKCONFIG) $@ arm arm926ejs tx25 karo mx25 > > The Makefile defined CONFIG_NAND_U_BOOT In principle you are right, too, but in include/configs/tx25.h: /* NAND BOOT is the only boot method */ #define CONFIG_NAND_U_BOOT CONFIG_NAND_U_BOOT is always defined for this board. No idea because there is a special rule in Makefile. > >> +tx25 arm arm926ejs tx25 karo mx25 > > This new entry fails to do that. Please make sure to add NAND_U_BOOT > in the "Options" column. I do not think we need it, because it is already defined in the config.h. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================