public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] MX25: tx25: Avoid the usage of extern in C file
@ 2011-08-29 20:30 Fabio Estevam
  2011-08-29 20:30 ` [U-Boot] [PATCH 2/2] MX25: Add initial support for MX25PDK Fabio Estevam
  0 siblings, 1 reply; 9+ messages in thread
From: Fabio Estevam @ 2011-08-29 20:30 UTC (permalink / raw)
  To: u-boot

Avoid the usage of extern in C file as pointed out by checkpatch.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/include/asm/arch-mx27/imx-regs.h |    1 +
 board/karo/tx25/tx25.c                    |    2 --
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/arm/include/asm/arch-mx27/imx-regs.h b/arch/arm/include/asm/arch-mx27/imx-regs.h
index b4b2fe6..0c1cda9 100644
--- a/arch/arm/include/asm/arch-mx27/imx-regs.h
+++ b/arch/arm/include/asm/arch-mx27/imx-regs.h
@@ -27,6 +27,7 @@
 #ifndef __ASSEMBLY__
 
 extern void imx_gpio_mode (int gpio_mode);
+extern void mx25_uart1_init_pins(void);
 
 #ifdef CONFIG_MXC_UART
 extern void mx27_uart1_init_pins(void);
diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c
index 25b99e8..c34672a 100644
--- a/board/karo/tx25/tx25.c
+++ b/board/karo/tx25/tx25.c
@@ -141,8 +141,6 @@ void tx25_fec_init(void)
 int board_init()
 {
 #ifdef CONFIG_MXC_UART
-	extern void mx25_uart1_init_pins(void);
-
 	mx25_uart1_init_pins();
 #endif
 	/* board id for linux */
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2011-08-30 10:01 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-29 20:30 [U-Boot] [PATCH 1/2] MX25: tx25: Avoid the usage of extern in C file Fabio Estevam
2011-08-29 20:30 ` [U-Boot] [PATCH 2/2] MX25: Add initial support for MX25PDK Fabio Estevam
2011-08-30  3:16   ` Jason Liu
2011-08-30  3:31     ` Fabio Estevam
2011-08-30  5:19       ` Wolfgang Denk
2011-08-30  5:19     ` Wolfgang Denk
2011-08-30  7:34   ` Stefano Babic
2011-08-30  9:36     ` Wolfgang Denk
2011-08-30 10:01       ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox