From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Thu, 01 Sep 2011 07:39:57 +0200 Subject: [U-Boot] [PATCH] bootp: Fix bug in auto_load function In-Reply-To: <20110831200152.1901918D30CE@gemini.denx.de> References: <1314786967-23261-1-git-send-email-monstr@monstr.eu> <20110831200152.1901918D30CE@gemini.denx.de> Message-ID: <4E5F1AAD.9010500@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Wolfgang Denk wrote: > Dear Michal Simek, > > In message <1314786967-23261-1-git-send-email-monstr@monstr.eu> you wrote: >> Patch: "Put common autoload code into auto_load() function" >> (sha1: 093498669e77597635a24f326f11efeab213d394) is not simple code >> cleanup but code change which introduce new bug. >> >> If autoload variable is not setup it worked as autoload=yes. > > Yes, and this is intentionally, because it's what poople expect when > they run the "dhcpboot" command. ok. > >> Currently if autoload is not setup dhcp sends request in >> forever loop. > > That's not correct. Only until a DHCP server provides the needed > configurationinformation so TFTP gets started. That's what I get/see on my platforms. > >> There are two options how to fix it: >> 1. Move TftpStart() which is in this patch >> 2. Change functionality if autoload is not setup, set NetSate and ends. > > That would change behavious in a way that is not wanted. Agree that point 2 change behavior. Point 1 just fix c&p error. Regards, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian