From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Simek <monstr@monstr.eu>
Date: Thu, 01 Sep 2011 11:21:31 +0200
Subject: [U-Boot] [PATCH v2] net: ll_temac: Add LL TEMAC driver to u-boot
In-Reply-To: <201108311526.27959.vapier@gentoo.org>
References: <1314705919-4237-1-git-send-email-monstr@monstr.eu>
	<201108311526.27959.vapier@gentoo.org>
Message-ID: <4E5F4E9B.1000103@monstr.eu>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Mike Frysinger wrote:
> On Tuesday, August 30, 2011 08:05:18 Michal Simek wrote:
>> +	volatile struct temac_reg *regs = priv->regs;
>> +
>> +	regs->lsw = (phy_addr << 5) | reg_addr;
>> +	regs->ctl = MIIMAI | (emac << 10);
> 
> you should still be going through read/write i/o helper funcs rather than 
> relying on the volatile markings

Fixed.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian