[U-Boot] [PATCH 03/15] Nokia RX-51 aka N900 support

Pali Rohár
2011-10-12T15:10:27Z

On Sunday 09 October 2011 11:59:29 Mike Frysinger wrote:
> On Saturday 08 October 2011 20:20:47 Pali Roh?r wrote:
> > On Thursday 01 September 2011 09:57:13 you wrote:
> > > On Thursday, September 01, 2011 07:34:29 Pali Roh?r wrote:
> > > > --- /dev/null
> > > > +++ b/board/nokia/rx51/rx51.c
> > > >
> > > > +GraphicDevice gdev;
> > >
> > > no camel case
> >
> > GraphicDevice is defined in include/video_fb.h
>
> ok, nothing you can do about that
>
> > > > --- /dev/null
> > > > +++ b/board/nokia/rx51/rx51.h
> > > >
> > > > +const omap3_sysinfo sysinfo = {
> > >
> > > you should not be defining variable storage in header files
> >
> > this code was derivated from board/ti/beagle/beagle.h and beagle.h still
> > has this code
>
> beagle.h is broken too. please don't copy their brokenness :).

Ok, this RX-51 code I mode into rx51.c (I hope it will be ok)

>
> > > > +/*
> > > > + * IEN - Input Enable
> > > > + * IDIS - Input Disable
> > > > + * PTD - Pull type Down
> > > > + * PTU - Pull type Up
> > > > + * DIS - Pull type selection is inactive
> > > > + * EN - Pull type selection is active
> > > > + * M0 - Mode 0
> > > > + * The commented string gives the final mux configuration for
> > > > that pin + */
> > >
> > > this looks like SoC info and not board specific. should this be in
> > > an
> > > SoC header somewhere instead ?
> >
> > all boards in board/ti/ has this code
>
> dumb behavior shouldn't be encouraged :). that indicates even more strongly
> that this should be in a SoC header somewhere.
> -mike

definitions of MUX are in arch/arm/include/asm/arch/mux.h and in rx51.h is used
these defines. Info in rx51.h is RX-51 specified, other ti boards have similar
but different code.

--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111012/945ccf24/attachment.pgp