[U-Boot] [PATCH v3] U-Boot on Nokia RX-51 (aka N900)

Graeme Russ
2011-12-19T08:43:33Z

Hi Pali,

On 19/12/11 18:17, Pali Roh?r wrote:
> On Monday 19 December 2011 00:57:27 Wolfgang Denk wrote:
>> Dear Pali =?ISO-8859-1?Q?Roh=E1r?=,
>>
>> In message <1778406.ezGto4lKnu@pali-elitebook> you wrote:
>>> I'm sending third version of rx51 patches for u-boot. All patches was
>>> checked by checkpatch.pl and no error or warning was appeared. Last 2
>>> patches (0014 and 0015) adding ANSI terminal bootmenu support for rx51
>>> and can be reviewed separatly (patches 0001-0013 adding nokia rx51
>>> board support and working without that last two).
>>
>> It seems you did not bother to read
>> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
>>
>> I do not have the time to try to find out what you might have changed
>> compared top your previous submission, and others are in the same
>> situation.
>>
>> Why did you not provide any change logs?
>>
>>
>>
>> Best regards,
>>
>> Wolfgang Denk
>
> Here is changelog v2:v3
>
> * fixed all problems detected by checkpatch.pl
> * wrapped long commit messages
> * in arch/arm/lib/bootm.c added local define CONFIG_SETUP_ANY_TAG
> * Patch "cfb_console.c: Add function console_swap_colors" squashed into
> "cfb_console.c: Add support for ANSI terminal"
> * renamed command clr to clear; use puts instead printf; move cursor to pos1,1
> * removed check #ifdef CONFIG_PREMONITOR in main.c
> * rx51 board code: removed Makefile targets: clean and distclean
> * ansi bootmenu command: use puts instead printf

So which patches have changed? What changes apply to which patch?

Before posting any more updates, please read:

http://www.denx.de/wiki/view/U-Boot/Patches

_completely_

In particular:
- Set the in-reply-to email header of the new version of _each_
_individual_ patch the the message-id: of the previous version of that
_individual_ patch
- Add v1/v2/v3 to the subject line of the updated version of _each_
_individual_ patch (i.e. [PATCH v2 06/15] ......) - You do not need to
post an new version of any patches which have no changes (you can if
you want to keep the version numbers the same across the whole series,
but make sure you put 'no changes' in the changelog)
- Include the changelog for all previous version of _each_ _individual_
patch on the new version of _each_ _individual_ patch - DO NOT put the
changelog in patch 0
- Use git format-patch and git send-email - git format-patch creates a
ready-to-send email - All you need to do is add the 'in-reply-to' email
header and chagelog and then do a git-send-email

We are fairly tolerant of honest mistakes (thankfully, because I've made my
fair share) but we tend to draw the line at mistakes that could have been
avoided with a little prior reading (particularly if said reading was
explicitly pointed out)

I suggest you create a 'v4' patchset after reading up on exactly how to
submit revised patches

Regards,

Graeme