public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dave Aldridge <fovsoft@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] ns16550: change to allow 32 bit access to registers
Date: Thu, 01 Sep 2011 17:00:30 +0100	[thread overview]
Message-ID: <4E5FAC1E.2070405@gmail.com> (raw)
In-Reply-To: <CAOZdJXVf1cBChOdM4vq6u7zbm3i5R_=akzjR16EOmd8mte2JkQ@mail.gmail.com>

Hi Tabi Timur-B04825

On 01/09/11 16:39, Tabi Timur-B04825 wrote:
> On Thu, Sep 1, 2011 at 6:40 AM, Dave Aldridge <fovsoft@gmail.com> wrote:
> 
>>  #if !defined(CONFIG_SYS_NS16550_REG_SIZE) || (CONFIG_SYS_NS16550_REG_SIZE == 0)
>>  #error "Please define NS16550 registers size."
>> +#elif defined(CONFIG_SYS_NS16550_MEM32)
>> +#define UART_REG(x) unsigned int x;
> 
> Shouldn't this be
> 
> #define UART_REG(x) u32 x
> 
> For one thing, I think you want a sized integer.  Secondly, does the
> semicolon at the end belong there?
> 

You are correct I have made an assumption about the size on a int. I will fix
this to remove any doubt.

Thanks for the comments

Cheers

Dave

  reply	other threads:[~2011-09-01 16:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01 11:40 [U-Boot] [PATCH v3] ns16550: change to allow 32 bit access to registers Dave Aldridge
2011-09-01 15:39 ` Tabi Timur-B04825
2011-09-01 16:00   ` Dave Aldridge [this message]
2011-09-07 21:22 ` Wolfgang Denk
2011-09-08  9:40   ` Dave Aldridge
2011-09-09 12:09   ` Detlev Zundel
2011-09-21  9:21     ` Dave Aldridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5FAC1E.2070405@gmail.com \
    --to=fovsoft@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox