From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Aldridge <fovsoft@gmail.com>
Date: Thu, 01 Sep 2011 17:00:30 +0100
Subject: [U-Boot] [PATCH v3] ns16550: change to allow 32 bit access to
 registers
In-Reply-To: <CAOZdJXVf1cBChOdM4vq6u7zbm3i5R_=akzjR16EOmd8mte2JkQ@mail.gmail.com>
References: <1314877212-31552-1-git-send-email-fovsoft@gmail.com>
	<CAOZdJXVf1cBChOdM4vq6u7zbm3i5R_=akzjR16EOmd8mte2JkQ@mail.gmail.com>
Message-ID: <4E5FAC1E.2070405@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tabi Timur-B04825

On 01/09/11 16:39, Tabi Timur-B04825 wrote:
> On Thu, Sep 1, 2011 at 6:40 AM, Dave Aldridge <fovsoft@gmail.com> wrote:
> 
>>  #if !defined(CONFIG_SYS_NS16550_REG_SIZE) || (CONFIG_SYS_NS16550_REG_SIZE == 0)
>>  #error "Please define NS16550 registers size."
>> +#elif defined(CONFIG_SYS_NS16550_MEM32)
>> +#define UART_REG(x) unsigned int x;
> 
> Shouldn't this be
> 
> #define UART_REG(x) u32 x
> 
> For one thing, I think you want a sized integer.  Secondly, does the
> semicolon at the end belong there?
> 

You are correct I have made an assumption about the size on a int. I will fix
this to remove any doubt.

Thanks for the comments

Cheers

Dave