From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 02 Sep 2011 09:22:33 +0200 Subject: [U-Boot] [PATCH v2 1/2] MX25: tx25: Avoid the usage of extern in C file In-Reply-To: <4E60825D.9060201@denx.de> References: <1314706823-16357-1-git-send-email-fabio.estevam@freescale.com> <4E60825D.9060201@denx.de> Message-ID: <4E608439.3010709@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/02/2011 09:14 AM, Stefano Babic wrote: > On 08/30/2011 02:20 PM, Fabio Estevam wrote: >> Avoid the usage of extern in C file as pointed out by checkpatch. >> >> Signed-off-by: Fabio Estevam >> --- > Hi Fabio, > Applied to u-boot-imx, as a fix, thanks. Sorry, it is not. Your patch introduces warnings for the tx25 board: Configuring for tx25 board... tx25.c: In function 'board_init': tx25.c:145: warning: implicit declaration of function 'mx25_uart1_init_pins' Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================