From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file
Date: Mon, 05 Sep 2011 12:43:18 +0200 [thread overview]
Message-ID: <4E64A7C6.9000208@denx.de> (raw)
In-Reply-To: <1314972139-20068-1-git-send-email-fabio.estevam@freescale.com>
On 09/02/2011 04:02 PM, Fabio Estevam wrote:
> Avoid the usage of extern in C file as pointed out by checkpatch.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Hi Fabio,
> diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h b/arch/arm/include/asm/arch-mx25/imx-regs.h
> index 9e30f7c..7e34050 100644
> --- a/arch/arm/include/asm/arch-mx25/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx25/imx-regs.h
> @@ -37,6 +37,7 @@
> #ifdef CONFIG_FEC_MXC
> extern void mx25_fec_init_pins(void);
> extern void imx_get_mac_from_fuse(unsigned char *mac);
> +extern void mx25_uart1_init_pins(void);
As i can see, in the imx-regs.h for the different processors there is
(as the name says) only definitions and structures for the internal
registers of each processor. No function prototypes.
What about to move the prototype ? For MX5/MX35 there is a sys_proto.h
(as it is done for other SOCs), in this case, well, it seems too much to
add a file for a single line. However, we could move it in clock.h and
creating a sys_proto.h if the number of exported functions will increase.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-09-05 10:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 14:02 [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file Fabio Estevam
2011-09-02 14:02 ` [U-Boot] [PATCH v3 2/2] MX25: Add initial support for MX25PDK Fabio Estevam
2011-09-05 10:43 ` Stefano Babic [this message]
2011-09-05 11:37 ` [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file Fabio Estevam
2011-09-05 13:05 ` Marek Vasut
2011-09-05 13:15 ` Fabio Estevam
2011-09-05 15:05 ` Marek Vasut
2011-09-05 15:38 ` Fabio Estevam
2011-09-05 15:40 ` Marek Vasut
2011-09-05 15:48 ` Fabio Estevam
2011-09-05 16:02 ` Wolfgang Denk
2011-09-05 16:12 ` Marek Vasut
2011-09-05 16:49 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E64A7C6.9000208@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox