From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 05 Sep 2011 12:43:18 +0200 Subject: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file In-Reply-To: <1314972139-20068-1-git-send-email-fabio.estevam@freescale.com> References: <1314972139-20068-1-git-send-email-fabio.estevam@freescale.com> Message-ID: <4E64A7C6.9000208@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/02/2011 04:02 PM, Fabio Estevam wrote: > Avoid the usage of extern in C file as pointed out by checkpatch. > > Signed-off-by: Fabio Estevam Hi Fabio, > diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h b/arch/arm/include/asm/arch-mx25/imx-regs.h > index 9e30f7c..7e34050 100644 > --- a/arch/arm/include/asm/arch-mx25/imx-regs.h > +++ b/arch/arm/include/asm/arch-mx25/imx-regs.h > @@ -37,6 +37,7 @@ > #ifdef CONFIG_FEC_MXC > extern void mx25_fec_init_pins(void); > extern void imx_get_mac_from_fuse(unsigned char *mac); > +extern void mx25_uart1_init_pins(void); As i can see, in the imx-regs.h for the different processors there is (as the name says) only definitions and structures for the internal registers of each processor. No function prototypes. What about to move the prototype ? For MX5/MX35 there is a sys_proto.h (as it is done for other SOCs), in this case, well, it seems too much to add a file for a single line. However, we could move it in clock.h and creating a sys_proto.h if the number of exported functions will increase. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================