From: Heiko Schocher <heiko.schocher@invitel.hu>
To: u-boot@lists.denx.de
Subject: [U-Boot] NULL base_name for hwaddr env lookup
Date: Mon, 05 Sep 2011 16:28:21 +0200 [thread overview]
Message-ID: <4E64DC85.7030301@invitel.hu> (raw)
In-Reply-To: <4E64D45F.5000308@novasys-ingenierie.com>
Hello MARCEL,
stany MARCEL wrote:
> in net/eth.c there is this function call with test:
>
> if (eth_write_hwaddr(dev, NULL, eth_number))
>
> If I understand correctly this test will always be true as NULL is used.
>
> I think it should be "eth" instead of NULL.
>
> Am I wrong ?
No.
> If not I can submit a patch.
See fix for this issue here:
http://patchwork.ozlabs.org/patch/112361/
bye,
Heiko
prev parent reply other threads:[~2011-09-05 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 13:53 [U-Boot] NULL base_name for hwaddr env lookup stany MARCEL
2011-09-05 14:26 ` Stany MARCEL
2011-09-05 14:28 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E64DC85.7030301@invitel.hu \
--to=heiko.schocher@invitel.hu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox