* [U-Boot] NULL base_name for hwaddr env lookup
@ 2011-09-05 13:53 stany MARCEL
2011-09-05 14:26 ` Stany MARCEL
2011-09-05 14:28 ` Heiko Schocher
0 siblings, 2 replies; 3+ messages in thread
From: stany MARCEL @ 2011-09-05 13:53 UTC (permalink / raw)
To: u-boot
in net/eth.c there is this function call with test:
if (eth_write_hwaddr(dev, NULL, eth_number))
If I understand correctly this test will always be true as NULL is used.
I think it should be "eth" instead of NULL.
Am I wrong ?
If not I can submit a patch.
Regards,
Stany
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] NULL base_name for hwaddr env lookup
2011-09-05 13:53 [U-Boot] NULL base_name for hwaddr env lookup stany MARCEL
@ 2011-09-05 14:26 ` Stany MARCEL
2011-09-05 14:28 ` Heiko Schocher
1 sibling, 0 replies; 3+ messages in thread
From: Stany MARCEL @ 2011-09-05 14:26 UTC (permalink / raw)
To: u-boot
On Mon, Sep 5, 2011 at 3:53 PM, stany MARCEL
<stany.marcel@novasys-ingenierie.com> wrote:
> in net/eth.c there is this function call with test:
>
> ?if (eth_write_hwaddr(dev, NULL, eth_number))
>
> If I understand correctly this test will always be true as NULL is used.
>
> I think it should be "eth" instead of NULL.
>
> Am I wrong ?
>
> If not I can submit a patch.
>
> Regards,
>
> Stany
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Ok it's corrected by a commit few minutes ago.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] NULL base_name for hwaddr env lookup
2011-09-05 13:53 [U-Boot] NULL base_name for hwaddr env lookup stany MARCEL
2011-09-05 14:26 ` Stany MARCEL
@ 2011-09-05 14:28 ` Heiko Schocher
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2011-09-05 14:28 UTC (permalink / raw)
To: u-boot
Hello MARCEL,
stany MARCEL wrote:
> in net/eth.c there is this function call with test:
>
> if (eth_write_hwaddr(dev, NULL, eth_number))
>
> If I understand correctly this test will always be true as NULL is used.
>
> I think it should be "eth" instead of NULL.
>
> Am I wrong ?
No.
> If not I can submit a patch.
See fix for this issue here:
http://patchwork.ozlabs.org/patch/112361/
bye,
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-05 14:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-05 13:53 [U-Boot] NULL base_name for hwaddr env lookup stany MARCEL
2011-09-05 14:26 ` Stany MARCEL
2011-09-05 14:28 ` Heiko Schocher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox