From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 05 Sep 2011 16:28:21 +0200 Subject: [U-Boot] NULL base_name for hwaddr env lookup In-Reply-To: <4E64D45F.5000308@novasys-ingenierie.com> References: <4E64D45F.5000308@novasys-ingenierie.com> Message-ID: <4E64DC85.7030301@invitel.hu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello MARCEL, stany MARCEL wrote: > in net/eth.c there is this function call with test: > > if (eth_write_hwaddr(dev, NULL, eth_number)) > > If I understand correctly this test will always be true as NULL is used. > > I think it should be "eth" instead of NULL. > > Am I wrong ? No. > If not I can submit a patch. See fix for this issue here: http://patchwork.ozlabs.org/patch/112361/ bye, Heiko