[U-Boot] [PATCH 1/2] net/eth.c: make eth_get_dev_by_name(NULL) safe

Mike Frysinger
2011-07-06T19:38:45Z

On Wednesday, July 06, 2011 03:15:08 Helmut Raiger wrote:
> On 07/05/2011 05:44 AM, Mike Frysinger wrote:
> > On Monday, July 04, 2011 06:29:51 helmut.raiger at hale.at wrote:
> >> eth_get_dev_by_name() is not safe to use for devname being NULL
> >> as it uses strcmp. This patch makes it return NULL if devname NULL
> >> is passed.
> >
> > i'm not sure about this. passing NULL is wrong, and the caller should
> > catch that shouldnt it ?
>
> So what is your suggestion how to deal with it?

in what situation is eth_get_dev_by_name(NULL) being called ? my suggestion
would be to fix that call point since it's doing something wrong.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110706/1e9ee21b/attachment.pgp