[U-Boot] [U-Boot PATCH MX31:] smc911x MII made available

Stefano Babic
2011-06-20T12:30:17Z

On 06/20/2011 08:10 AM, Helmut.Raiger at hale.at wrote:
> From: Helmut Raiger <helmut.raiger@hale.at>

Hi Helmut,

>
> The driver already had the MII functions, but they have not been
> registered using miiphy_register().
>
> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>

Not noted before, thanks for fixing it. Only to remark the issue, on
boards with SMC911x (at least the one I tested your patch) and
CONFIG_CMD_MII set, a simple "mii info" returns "Read MDIO failed.."

You should always put in CC the maintainer for your patches. Because
this patch is related to network, you should send your changes to
Wolfgang Denk (Network Maintaner), too. I have already set his name in CC.

> +#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
> +/* wrapper for smc911x_miiphy_read */
> +static int _phy_read(char *devname, u8 phy, u8 reg, u16 *val)

Is there some reason to use name starting with _ ? They have special
meaning, and there is no need here.

I have tested your patch on the mx35pdk board.

Tested-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================