[U-Boot] [PATCH] net: Add \n before warning message so it prints on a new line.

Philip Balister
2011-09-08T15:04:56Z

On 09/08/2011 11:01 AM, Albert ARIBAUD wrote:
> Hi Philip,
>
> Le 07/09/2011 13:57, Philip Balister a ?crit :
>> Signed-off-by: Philip Balister<philip@opensdr.com>
>> ---
>> net/eth.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/eth.c b/net/eth.c
>> index dbd1e2d..67a8039 100644
>> --- a/net/eth.c
>> +++ b/net/eth.c
>> @@ -305,7 +305,7 @@ int eth_initialize(bd_t *bis)
>> puts("\nWarning: eth device name has a space!\n");
>>
>> if (eth_write_hwaddr(dev, "eth", eth_number))
>> - puts("Warning: failed to set MAC address\n");
>> + puts("\nWarning: failed to set MAC address\n");
>
> I believe warning messages with \n on more than one end are frowned upon.

Look closely at the patch, the warning message above has to do the same
thing. Without the leading \n on the message, it prints directly after
the ethernet chip name, with no space. This is not right. I chose to
copy the existing code, rather than add a leading space.

Philip

>
>> eth_number++;
>> dev = dev->next;
>
> Amicalement,