[U-Boot] [PATCH 12/31] iMX28: Add I2C bus driver

Stefan Roese
2011-09-09T11:26:18Z

Hi Marek,

On Friday 09 September 2011 13:18:40 Marek Vasut wrote:
> > > + if (tmp & (
> > > + I2C_CTRL1_EARLY_TERM_IRQ | I2C_CTRL1_MASTER_LOSS_IRQ |
> > > + I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ
> > > + )) {
> >
> > Checkpatch don;t beats here, but I think, two line are not necessary
> >
> > here, just do a:
> > I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ)) {
> >
> > Beside of that, patch looks good to me, so:
> I think it's more readable as it is ... what do the others think ?

I'm definitely with Heiko here! ;)

Ciao,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de