From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 09 Sep 2011 14:34:05 +0200 Subject: [U-Boot] [PATCH 18/31] iMX28: Add SPI driver In-Reply-To: <201109091350.16806.marek.vasut@gmail.com> References: <1315514579-19215-1-git-send-email-marek.vasut@gmail.com> <1315514579-19215-19-git-send-email-marek.vasut@gmail.com> <4E69D385.1050203@denx.de> <201109091350.16806.marek.vasut@gmail.com> Message-ID: <4E6A07BD.8010103@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/09/2011 01:50 PM, Marek Vasut wrote: >> >> Only the CS supplied in the SOC are supported, it is not possible to use >> a GPIO. Please add a comment to explain that. If you see other SPI drivers (mxc_spi.c, or blackfin, and other, too) the CS is or can be implemented with a gpio. Some architecture have a board specific spi_cs_activate. In your driver, only the CS of the SPI controller are supported. My only remark is if we can add a comment to explain this. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================