public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
@ 2011-09-09  7:17 Stefano Babic
  2011-09-09  7:36 ` Wolfgang Denk
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Stefano Babic @ 2011-09-09  7:17 UTC (permalink / raw)
  To: u-boot

get_ram_size() is called, but memsize.c is not compiled.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
index b3f4bd6..65ed055 100644
--- a/nand_spl/board/davinci/da8xxevm/Makefile
+++ b/nand_spl/board/davinci/da8xxevm/Makefile
@@ -38,7 +38,7 @@ CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 
 SOBJS	= start.o _udivsi3.o _divsi3.o
 COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
-	misc.o hawkboard_nand_spl.o nand_boot.o
+	misc.o hawkboard_nand_spl.o nand_boot.o memsize.o
 
 SRCS	:= $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -125,6 +125,10 @@ $(obj)psc.c:
 	@rm -f $@
 	ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@
 
+# from comon directory
+$(obj)memsize.c:
+	@rm -f $@
+	ln -s $(TOPDIR)/common/memsize.c $@
 
 #########################################################################
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  7:17 Stefano Babic
@ 2011-09-09  7:36 ` Wolfgang Denk
  2011-09-09  9:04   ` Stefano Babic
  2011-09-09  9:23 ` Stefano Babic
  2011-09-09 20:34 ` Paulraj, Sandeep
  2 siblings, 1 reply; 14+ messages in thread
From: Wolfgang Denk @ 2011-09-09  7:36 UTC (permalink / raw)
  To: u-boot

Dear Stefano Babic,

In message <1315552622-27566-1-git-send-email-sbabic@denx.de> you wrote:
> get_ram_size() is called, but memsize.c is not compiled.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>  nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
> index b3f4bd6..65ed055 100644
> --- a/nand_spl/board/davinci/da8xxevm/Makefile
> +++ b/nand_spl/board/davinci/da8xxevm/Makefile
> @@ -38,7 +38,7 @@ CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
>  
>  SOBJS	= start.o _udivsi3.o _divsi3.o
>  COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
> -	misc.o hawkboard_nand_spl.o nand_boot.o
> +	misc.o hawkboard_nand_spl.o nand_boot.o memsize.o

Please split these litst (one object name per line), and sort them.

> +# from comon directory
> +$(obj)memsize.c:
> +	@rm -f $@
> +	ln -s $(TOPDIR)/common/memsize.c $@

Can we not rather compile the file in the common directory instead?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The heart is not a logical organ.
	-- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  7:36 ` Wolfgang Denk
@ 2011-09-09  9:04   ` Stefano Babic
  2011-09-12 11:05     ` Sughosh Ganu
  0 siblings, 1 reply; 14+ messages in thread
From: Stefano Babic @ 2011-09-09  9:04 UTC (permalink / raw)
  To: u-boot

On 09/09/2011 09:36 AM, Wolfgang Denk wrote:
> Dear Stefano Babic,
> 
> In message <1315552622-27566-1-git-send-email-sbabic@denx.de> you wrote:
>> get_ram_size() is called, but memsize.c is not compiled.
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> ---
>>  nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
>>  1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
>> index b3f4bd6..65ed055 100644
>> --- a/nand_spl/board/davinci/da8xxevm/Makefile
>> +++ b/nand_spl/board/davinci/da8xxevm/Makefile
>> @@ -38,7 +38,7 @@ CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
>>  
>>  SOBJS	= start.o _udivsi3.o _divsi3.o
>>  COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
>> -	misc.o hawkboard_nand_spl.o nand_boot.o
>> +	misc.o hawkboard_nand_spl.o nand_boot.o memsize.o
> 
> Please split these litst (one object name per line), and sort them.

Ok.

> 
>> +# from comon directory
>> +$(obj)memsize.c:
>> +	@rm -f $@
>> +	ln -s $(TOPDIR)/common/memsize.c $@
> 
> Can we not rather compile the file in the common directory instead?

This is only for nand_spl, not for u-boot. The nand_spl/board/Makefile
has the list of files that must be compiled. Of course, the file was
already compiled in common for u-boot.bin.

Not sure why this issue appears now. Rebuilding all ARM boards I see
that hawkboard is broken, I have not bisect to check when it happened.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  7:17 Stefano Babic
  2011-09-09  7:36 ` Wolfgang Denk
@ 2011-09-09  9:23 ` Stefano Babic
  2011-09-09  9:36   ` Stefano Babic
  2011-09-09 20:34 ` Paulraj, Sandeep
  2 siblings, 1 reply; 14+ messages in thread
From: Stefano Babic @ 2011-09-09  9:23 UTC (permalink / raw)
  To: u-boot

get_ram_size() is called, but memsize.c is not compiled.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
index b3f4bd6..65ed055 100644
--- a/nand_spl/board/davinci/da8xxevm/Makefile
+++ b/nand_spl/board/davinci/da8xxevm/Makefile
@@ -38,7 +38,7 @@ CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 
 SOBJS	= start.o _udivsi3.o _divsi3.o
 COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
-	misc.o hawkboard_nand_spl.o nand_boot.o
+	misc.o hawkboard_nand_spl.o nand_boot.o memsize.o
 
 SRCS	:= $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -125,6 +125,10 @@ $(obj)psc.c:
 	@rm -f $@
 	ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@
 
+# from comon directory
+$(obj)memsize.c:
+	@rm -f $@
+	ln -s $(TOPDIR)/common/memsize.c $@
 
 #########################################################################
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  9:23 ` Stefano Babic
@ 2011-09-09  9:36   ` Stefano Babic
  0 siblings, 0 replies; 14+ messages in thread
From: Stefano Babic @ 2011-09-09  9:36 UTC (permalink / raw)
  To: u-boot

On 09/09/2011 11:23 AM, Stefano Babic wrote:
> get_ram_size() is called, but memsize.c is not compiled.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---

Sorry, forget it. I sent again V1 of the patch...

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  7:17 Stefano Babic
  2011-09-09  7:36 ` Wolfgang Denk
  2011-09-09  9:23 ` Stefano Babic
@ 2011-09-09 20:34 ` Paulraj, Sandeep
  2 siblings, 0 replies; 14+ messages in thread
From: Paulraj, Sandeep @ 2011-09-09 20:34 UTC (permalink / raw)
  To: u-boot



> get_ram_size() is called, but memsize.c is not compiled.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>  nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)

Pushed to u-boot-ti

--Sandeep

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
@ 2011-09-10 20:28 Wolfgang Denk
  2011-09-10 20:46 ` Wolfgang Denk
  0 siblings, 1 reply; 14+ messages in thread
From: Wolfgang Denk @ 2011-09-10 20:28 UTC (permalink / raw)
  To: u-boot

Fix build problem:

nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot'
nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Syed Mohammed Khasim <sm.khasim@gmail.com>
Cc: Sughosh Ganu <urwithsughosh@gmail.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
---
 board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/board/davinci/da8xxevm/hawkboard_nand_spl.c b/board/davinci/da8xxevm/hawkboard_nand_spl.c
index 9155236..e5e65e5 100644
--- a/board/davinci/da8xxevm/hawkboard_nand_spl.c
+++ b/board/davinci/da8xxevm/hawkboard_nand_spl.c
@@ -28,6 +28,7 @@
 #include <asm/io.h>
 #include <asm/arch/davinci_misc.h>
 #include <ns16550.h>
+#include <nand.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
-- 
1.7.6

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-10 20:28 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Wolfgang Denk
@ 2011-09-10 20:46 ` Wolfgang Denk
  2011-09-11 15:59   ` Albert ARIBAUD
  0 siblings, 1 reply; 14+ messages in thread
From: Wolfgang Denk @ 2011-09-10 20:46 UTC (permalink / raw)
  To: u-boot

Dear Wolfgang Denk,

In message <1315686495-9133-1-git-send-email-wd@denx.de> you wrote:
> Fix build problem:
> 
> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot'
> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Syed Mohammed Khasim <sm.khasim@gmail.com>
> Cc: Sughosh Ganu <urwithsughosh@gmail.com>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>  board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An optimist believes we live in the best world possible; a  pessimist
fears this is true.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-10 20:46 ` Wolfgang Denk
@ 2011-09-11 15:59   ` Albert ARIBAUD
  2011-09-11 16:11     ` Albert ARIBAUD
  2011-09-11 18:03     ` Wolfgang Denk
  0 siblings, 2 replies; 14+ messages in thread
From: Albert ARIBAUD @ 2011-09-11 15:59 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

Le 10/09/2011 22:46, Wolfgang Denk a ?crit :
> Dear Wolfgang Denk,
>
> In message<1315686495-9133-1-git-send-email-wd@denx.de>  you wrote:
>> Fix build problem:
>>
>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot'
>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return
>>
>> Signed-off-by: Wolfgang Denk<wd@denx.de>
>> Cc: Syed Mohammed Khasim<sm.khasim@gmail.com>
>> Cc: Sughosh Ganu<urwithsughosh@gmail.com>
>> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
>> ---
>>   board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> Applied, thanks.
>
> Best regards,
>
> Wolfgang Denk

I'd already applied this patch from Stefano to u-boot-arm/master.

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-11 15:59   ` Albert ARIBAUD
@ 2011-09-11 16:11     ` Albert ARIBAUD
  2011-09-11 18:04       ` Wolfgang Denk
  2011-09-11 18:03     ` Wolfgang Denk
  1 sibling, 1 reply; 14+ messages in thread
From: Albert ARIBAUD @ 2011-09-11 16:11 UTC (permalink / raw)
  To: u-boot

Le 11/09/2011 17:59, Albert ARIBAUD a ?crit :
> Hi Wolfgang,
>
> Le 10/09/2011 22:46, Wolfgang Denk a ?crit :
>> Dear Wolfgang Denk,
>>
>> In message<1315686495-9133-1-git-send-email-wd@denx.de>   you wrote:
>>> Fix build problem:
>>>
>>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
>>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot'
>>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return
>>>
>>> Signed-off-by: Wolfgang Denk<wd@denx.de>
>>> Cc: Syed Mohammed Khasim<sm.khasim@gmail.com>
>>> Cc: Sughosh Ganu<urwithsughosh@gmail.com>
>>> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
>>> ---
>>>    board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
>>>    1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> Applied, thanks.
>>
>> Best regards,
>>
>> Wolfgang Denk
>
> I'd already applied this patch from Stefano to u-boot-arm/master.

Correction: you, not I, had already applied a patch with the exact same 
title and different content.

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-11 15:59   ` Albert ARIBAUD
  2011-09-11 16:11     ` Albert ARIBAUD
@ 2011-09-11 18:03     ` Wolfgang Denk
  1 sibling, 0 replies; 14+ messages in thread
From: Wolfgang Denk @ 2011-09-11 18:03 UTC (permalink / raw)
  To: u-boot

Dear Albert ARIBAUD,

In message <4E6CDAEB.6050404@aribaud.net> you wrote:
> 
> I'd already applied this patch from Stefano to u-boot-arm/master.

This is no problem - git will sort it out automatically.

Sorry for going ahead, I wanted to clean up the ARM build finally.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It all seemed, he thought, to be rather a lot of  trouble  to  go  to
just sharpen a razor blade.  - Terry Pratchett, _The Light Fantastic_

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-11 16:11     ` Albert ARIBAUD
@ 2011-09-11 18:04       ` Wolfgang Denk
  0 siblings, 0 replies; 14+ messages in thread
From: Wolfgang Denk @ 2011-09-11 18:04 UTC (permalink / raw)
  To: u-boot

Dear Albert ARIBAUD,

In message <4E6CDDC8.5040300@aribaud.net> you wrote:
>
> > I'd already applied this patch from Stefano to u-boot-arm/master.
> 
> Correction: you, not I, had already applied a patch with the exact same 
> title and different content.

Yes, there were several problems with this board :-(

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We're all sorry for the other guy when he loses his job to a machine.
But when it comes to your job -- that's different. And it always will
be different.
	-- McCoy, "The Ultimate Computer", stardate 4729.4

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  9:04   ` Stefano Babic
@ 2011-09-12 11:05     ` Sughosh Ganu
  2011-09-12 13:16       ` Stefano Babic
  0 siblings, 1 reply; 14+ messages in thread
From: Sughosh Ganu @ 2011-09-12 11:05 UTC (permalink / raw)
  To: u-boot

hi Stefano,

On Fri Sep 09, 2011 at 11:04:14AM +0200, Stefano Babic wrote:
> On 09/09/2011 09:36 AM, Wolfgang Denk wrote:

<snip>

> > 
> >> +# from comon directory
> >> +$(obj)memsize.c:
> >> +	@rm -f $@
> >> +	ln -s $(TOPDIR)/common/memsize.c $@
> > 
> > Can we not rather compile the file in the common directory instead?
> 
> This is only for nand_spl, not for u-boot. The nand_spl/board/Makefile
> has the list of files that must be compiled. Of course, the file was
> already compiled in common for u-boot.bin.
> 
> Not sure why this issue appears now. Rebuilding all ARM boards I see
> that hawkboard is broken, I have not bisect to check when it happened.

  Sorry for not having caught this earlier. I ran git bisect on this,
  and the commit "401bb30b6d replace CONFIG_PRELOADER with
  CONFIG_SPL_BUILD" seems to be causing the build break.

  The issue seems to be that the code in board/davinci/common/misc.c
  gets conditionally compiled based on definition of CONFIG_PRELOADER
  symbol, which was removed in this commit, and replaced by
  CONFIG_SPL_BUILD. I think we should correspondingly change this
  check in misc.c, so that it would not be required to compile in
  memsize.c. Let me know, and i will test this change and send out a
  patch. Thanks.

-sughosh

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-12 11:05     ` Sughosh Ganu
@ 2011-09-12 13:16       ` Stefano Babic
  0 siblings, 0 replies; 14+ messages in thread
From: Stefano Babic @ 2011-09-12 13:16 UTC (permalink / raw)
  To: u-boot

On 09/12/2011 01:05 PM, Sughosh Ganu wrote:
> hi Stefano,
> 
> On Fri Sep 09, 2011 at 11:04:14AM +0200, Stefano Babic wrote:
>> On 09/09/2011 09:36 AM, Wolfgang Denk wrote:
> 
> <snip>

Hi Sughosh,

> 
>   Sorry for not having caught this earlier. I ran git bisect on this,
>   and the commit "401bb30b6d replace CONFIG_PRELOADER with
>   CONFIG_SPL_BUILD" seems to be causing the build break.
> 
>   The issue seems to be that the code in board/davinci/common/misc.c
>   gets conditionally compiled based on definition of CONFIG_PRELOADER
>   symbol, which was removed in this commit, and replaced by
>   CONFIG_SPL_BUILD.

Yes, right.


> I think we should correspondingly change this
>   check in misc.c, so that it would not be required to compile in
>   memsize.c. Let me know, and i will test this change and send out a
>   patch. Thanks.

Agree. This is the right solution.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2011-09-12 13:16 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-10 20:28 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Wolfgang Denk
2011-09-10 20:46 ` Wolfgang Denk
2011-09-11 15:59   ` Albert ARIBAUD
2011-09-11 16:11     ` Albert ARIBAUD
2011-09-11 18:04       ` Wolfgang Denk
2011-09-11 18:03     ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2011-09-09  7:17 Stefano Babic
2011-09-09  7:36 ` Wolfgang Denk
2011-09-09  9:04   ` Stefano Babic
2011-09-12 11:05     ` Sughosh Ganu
2011-09-12 13:16       ` Stefano Babic
2011-09-09  9:23 ` Stefano Babic
2011-09-09  9:36   ` Stefano Babic
2011-09-09 20:34 ` Paulraj, Sandeep

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox