public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
@ 2011-09-09  7:17 Stefano Babic
  2011-09-09  7:36 ` Wolfgang Denk
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Stefano Babic @ 2011-09-09  7:17 UTC (permalink / raw)
  To: u-boot

get_ram_size() is called, but memsize.c is not compiled.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
index b3f4bd6..65ed055 100644
--- a/nand_spl/board/davinci/da8xxevm/Makefile
+++ b/nand_spl/board/davinci/da8xxevm/Makefile
@@ -38,7 +38,7 @@ CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 
 SOBJS	= start.o _udivsi3.o _divsi3.o
 COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
-	misc.o hawkboard_nand_spl.o nand_boot.o
+	misc.o hawkboard_nand_spl.o nand_boot.o memsize.o
 
 SRCS	:= $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -125,6 +125,10 @@ $(obj)psc.c:
 	@rm -f $@
 	ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@
 
+# from comon directory
+$(obj)memsize.c:
+	@rm -f $@
+	ln -s $(TOPDIR)/common/memsize.c $@
 
 #########################################################################
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  7:17 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Stefano Babic
@ 2011-09-09  7:36 ` Wolfgang Denk
  2011-09-09  9:04   ` Stefano Babic
  2011-09-09  9:23 ` Stefano Babic
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Wolfgang Denk @ 2011-09-09  7:36 UTC (permalink / raw)
  To: u-boot

Dear Stefano Babic,

In message <1315552622-27566-1-git-send-email-sbabic@denx.de> you wrote:
> get_ram_size() is called, but memsize.c is not compiled.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>  nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
> index b3f4bd6..65ed055 100644
> --- a/nand_spl/board/davinci/da8xxevm/Makefile
> +++ b/nand_spl/board/davinci/da8xxevm/Makefile
> @@ -38,7 +38,7 @@ CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
>  
>  SOBJS	= start.o _udivsi3.o _divsi3.o
>  COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
> -	misc.o hawkboard_nand_spl.o nand_boot.o
> +	misc.o hawkboard_nand_spl.o nand_boot.o memsize.o

Please split these litst (one object name per line), and sort them.

> +# from comon directory
> +$(obj)memsize.c:
> +	@rm -f $@
> +	ln -s $(TOPDIR)/common/memsize.c $@

Can we not rather compile the file in the common directory instead?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The heart is not a logical organ.
	-- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  7:36 ` Wolfgang Denk
@ 2011-09-09  9:04   ` Stefano Babic
  2011-09-12 11:05     ` Sughosh Ganu
  0 siblings, 1 reply; 14+ messages in thread
From: Stefano Babic @ 2011-09-09  9:04 UTC (permalink / raw)
  To: u-boot

On 09/09/2011 09:36 AM, Wolfgang Denk wrote:
> Dear Stefano Babic,
> 
> In message <1315552622-27566-1-git-send-email-sbabic@denx.de> you wrote:
>> get_ram_size() is called, but memsize.c is not compiled.
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> ---
>>  nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
>>  1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
>> index b3f4bd6..65ed055 100644
>> --- a/nand_spl/board/davinci/da8xxevm/Makefile
>> +++ b/nand_spl/board/davinci/da8xxevm/Makefile
>> @@ -38,7 +38,7 @@ CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
>>  
>>  SOBJS	= start.o _udivsi3.o _divsi3.o
>>  COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
>> -	misc.o hawkboard_nand_spl.o nand_boot.o
>> +	misc.o hawkboard_nand_spl.o nand_boot.o memsize.o
> 
> Please split these litst (one object name per line), and sort them.

Ok.

> 
>> +# from comon directory
>> +$(obj)memsize.c:
>> +	@rm -f $@
>> +	ln -s $(TOPDIR)/common/memsize.c $@
> 
> Can we not rather compile the file in the common directory instead?

This is only for nand_spl, not for u-boot. The nand_spl/board/Makefile
has the list of files that must be compiled. Of course, the file was
already compiled in common for u-boot.bin.

Not sure why this issue appears now. Rebuilding all ARM boards I see
that hawkboard is broken, I have not bisect to check when it happened.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  7:17 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Stefano Babic
  2011-09-09  7:36 ` Wolfgang Denk
@ 2011-09-09  9:23 ` Stefano Babic
  2011-09-09  9:36   ` Stefano Babic
  2011-09-09  9:37 ` [U-Boot] [PATCH] ARM: hawkboard_nand: " Stefano Babic
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Stefano Babic @ 2011-09-09  9:23 UTC (permalink / raw)
  To: u-boot

get_ram_size() is called, but memsize.c is not compiled.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
index b3f4bd6..65ed055 100644
--- a/nand_spl/board/davinci/da8xxevm/Makefile
+++ b/nand_spl/board/davinci/da8xxevm/Makefile
@@ -38,7 +38,7 @@ CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 
 SOBJS	= start.o _udivsi3.o _divsi3.o
 COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
-	misc.o hawkboard_nand_spl.o nand_boot.o
+	misc.o hawkboard_nand_spl.o nand_boot.o memsize.o
 
 SRCS	:= $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -125,6 +125,10 @@ $(obj)psc.c:
 	@rm -f $@
 	ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@
 
+# from comon directory
+$(obj)memsize.c:
+	@rm -f $@
+	ln -s $(TOPDIR)/common/memsize.c $@
 
 #########################################################################
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  9:23 ` Stefano Babic
@ 2011-09-09  9:36   ` Stefano Babic
  0 siblings, 0 replies; 14+ messages in thread
From: Stefano Babic @ 2011-09-09  9:36 UTC (permalink / raw)
  To: u-boot

On 09/09/2011 11:23 AM, Stefano Babic wrote:
> get_ram_size() is called, but memsize.c is not compiled.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---

Sorry, forget it. I sent again V1 of the patch...

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard_nand: fix compilation of nand_spl
  2011-09-09  7:17 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Stefano Babic
  2011-09-09  7:36 ` Wolfgang Denk
  2011-09-09  9:23 ` Stefano Babic
@ 2011-09-09  9:37 ` Stefano Babic
  2011-09-09 11:40   ` Wolfgang Denk
  2011-09-09 13:09 ` [U-Boot] [PATCH V2] " Stefano Babic
  2011-09-09 20:34 ` [U-Boot] [PATCH] ARM: hawkboard: " Paulraj, Sandeep
  4 siblings, 1 reply; 14+ messages in thread
From: Stefano Babic @ 2011-09-09  9:37 UTC (permalink / raw)
  To: u-boot

get_ram_size() is called, but memsize.c is not compiled.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 nand_spl/board/davinci/da8xxevm/Makefile |   21 ++++++++++++++++++---
 1 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
index b3f4bd6..c82f6c6 100644
--- a/nand_spl/board/davinci/da8xxevm/Makefile
+++ b/nand_spl/board/davinci/da8xxevm/Makefile
@@ -36,9 +36,20 @@ LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \
 AFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 
-SOBJS	= start.o _udivsi3.o _divsi3.o
-COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
-	misc.o hawkboard_nand_spl.o nand_boot.o
+SOBJS	= _divsi3.o \
+	_udivsi3.o \
+	start.o
+
+COBJS	= cpu.o \
+	davinci_nand.o \
+	davinci_pinmux.o \
+	div0.o \
+	hawkboard_nand_spl.o \
+	memsize.o \
+	misc.o \
+	nand_boot.o \
+	ns16550.o \
+	psc.o
 
 SRCS	:= $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -125,6 +136,10 @@ $(obj)psc.c:
 	@rm -f $@
 	ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@
 
+# from comon directory
+$(obj)memsize.c:
+	@rm -f $@
+	ln -s $(TOPDIR)/common/memsize.c $@
 
 #########################################################################
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard_nand: fix compilation of nand_spl
  2011-09-09  9:37 ` [U-Boot] [PATCH] ARM: hawkboard_nand: " Stefano Babic
@ 2011-09-09 11:40   ` Wolfgang Denk
  2011-09-09 12:40     ` Stefano Babic
  0 siblings, 1 reply; 14+ messages in thread
From: Wolfgang Denk @ 2011-09-09 11:40 UTC (permalink / raw)
  To: u-boot

Dear Stefano Babic,

In message <1315561023-7015-1-git-send-email-sbabic@denx.de> you wrote:
> get_ram_size() is called, but memsize.c is not compiled.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>  nand_spl/board/davinci/da8xxevm/Makefile |   21 ++++++++++++++++++---
>  1 files changed, 18 insertions(+), 3 deletions(-)

So, what is this now?  v1? v2? anything else?

And what exactly has been changed?

Why is there no version in the Subject, and no Changelog in the
comment section?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A witty saying proves nothing, but saying  something  pointless  gets
people's attention.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard_nand: fix compilation of nand_spl
  2011-09-09 11:40   ` Wolfgang Denk
@ 2011-09-09 12:40     ` Stefano Babic
  0 siblings, 0 replies; 14+ messages in thread
From: Stefano Babic @ 2011-09-09 12:40 UTC (permalink / raw)
  To: u-boot

On 09/09/2011 01:40 PM, Wolfgang Denk wrote:
> Dear Stefano Babic,
> 
> In message <1315561023-7015-1-git-send-email-sbabic@denx.de> you wrote:
>> get_ram_size() is called, but memsize.c is not compiled.
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> ---
>>  nand_spl/board/davinci/da8xxevm/Makefile |   21 ++++++++++++++++++---
>>  1 files changed, 18 insertions(+), 3 deletions(-)
> 
> So, what is this now?  v1? v2? anything else?
> 
> And what exactly has been changed?
> 
> Why is there no version in the Subject, and no Changelog in the
> comment section?

There is only one reason: I forget to do it !

ok, I will try again...

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH V2] ARM: hawkboard_nand: fix compilation of nand_spl
  2011-09-09  7:17 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Stefano Babic
                   ` (2 preceding siblings ...)
  2011-09-09  9:37 ` [U-Boot] [PATCH] ARM: hawkboard_nand: " Stefano Babic
@ 2011-09-09 13:09 ` Stefano Babic
  2011-09-10 14:13   ` Wolfgang Denk
  2011-09-09 20:34 ` [U-Boot] [PATCH] ARM: hawkboard: " Paulraj, Sandeep
  4 siblings, 1 reply; 14+ messages in thread
From: Stefano Babic @ 2011-09-09 13:09 UTC (permalink / raw)
  To: u-boot

get_ram_size() is called, but memsize.c is not compiled.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---

Changes since V1:
- make list sorted (Wolfgang Denk)

 nand_spl/board/davinci/da8xxevm/Makefile |   21 ++++++++++++++++++---
 1 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
index b3f4bd6..c82f6c6 100644
--- a/nand_spl/board/davinci/da8xxevm/Makefile
+++ b/nand_spl/board/davinci/da8xxevm/Makefile
@@ -36,9 +36,20 @@ LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \
 AFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 
-SOBJS	= start.o _udivsi3.o _divsi3.o
-COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
-	misc.o hawkboard_nand_spl.o nand_boot.o
+SOBJS	= _divsi3.o \
+	_udivsi3.o \
+	start.o
+
+COBJS	= cpu.o \
+	davinci_nand.o \
+	davinci_pinmux.o \
+	div0.o \
+	hawkboard_nand_spl.o \
+	memsize.o \
+	misc.o \
+	nand_boot.o \
+	ns16550.o \
+	psc.o
 
 SRCS	:= $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -125,6 +136,10 @@ $(obj)psc.c:
 	@rm -f $@
 	ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@
 
+# from common directory
+$(obj)memsize.c:
+	@rm -f $@
+	ln -s $(TOPDIR)/common/memsize.c $@
 
 #########################################################################
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  7:17 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Stefano Babic
                   ` (3 preceding siblings ...)
  2011-09-09 13:09 ` [U-Boot] [PATCH V2] " Stefano Babic
@ 2011-09-09 20:34 ` Paulraj, Sandeep
  4 siblings, 0 replies; 14+ messages in thread
From: Paulraj, Sandeep @ 2011-09-09 20:34 UTC (permalink / raw)
  To: u-boot



> get_ram_size() is called, but memsize.c is not compiled.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>  nand_spl/board/davinci/da8xxevm/Makefile |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)

Pushed to u-boot-ti

--Sandeep

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH V2] ARM: hawkboard_nand: fix compilation of nand_spl
  2011-09-09 13:09 ` [U-Boot] [PATCH V2] " Stefano Babic
@ 2011-09-10 14:13   ` Wolfgang Denk
  2011-09-11 16:19     ` Albert ARIBAUD
  0 siblings, 1 reply; 14+ messages in thread
From: Wolfgang Denk @ 2011-09-10 14:13 UTC (permalink / raw)
  To: u-boot

Dear Stefano Babic,

In message <1315573742-10128-1-git-send-email-sbabic@denx.de> you wrote:
> get_ram_size() is called, but memsize.c is not compiled.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
> 
> Changes since V1:
> - make list sorted (Wolfgang Denk)
> 
>  nand_spl/board/davinci/da8xxevm/Makefile |   21 ++++++++++++++++++---
>  1 files changed, 18 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nearly everyone is in favor of going  to  heaven  but  too  many  are
hoping  they'll  live  long  enough  to see an easing of the entrance
requirements. Never appeal to a man's "better nature." he  might  not
have one.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH V2] ARM: hawkboard_nand: fix compilation of nand_spl
  2011-09-10 14:13   ` Wolfgang Denk
@ 2011-09-11 16:19     ` Albert ARIBAUD
  0 siblings, 0 replies; 14+ messages in thread
From: Albert ARIBAUD @ 2011-09-11 16:19 UTC (permalink / raw)
  To: u-boot

Le 10/09/2011 16:13, Wolfgang Denk a ?crit :
> Dear Stefano Babic,
>
> In message<1315573742-10128-1-git-send-email-sbabic@denx.de>  you wrote:
>> get_ram_size() is called, but memsize.c is not compiled.
>>
>> Signed-off-by: Stefano Babic<sbabic@denx.de>
>> ---
>>
>> Changes since V1:
>> - make list sorted (Wolfgang Denk)
>>
>>   nand_spl/board/davinci/da8xxevm/Makefile |   21 ++++++++++++++++++---
>>   1 files changed, 18 insertions(+), 3 deletions(-)
>
> Applied, thanks.

Note:

This patch was also pushed to the u-boot-ti tree by Sandeep, then pulled 
in mine, but it was V1. I'm rebasing u-boot-arm onto u-boot and picking 
your version as it is V2.

> Best regards,
>
> Wolfgang Denk

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-09  9:04   ` Stefano Babic
@ 2011-09-12 11:05     ` Sughosh Ganu
  2011-09-12 13:16       ` Stefano Babic
  0 siblings, 1 reply; 14+ messages in thread
From: Sughosh Ganu @ 2011-09-12 11:05 UTC (permalink / raw)
  To: u-boot

hi Stefano,

On Fri Sep 09, 2011 at 11:04:14AM +0200, Stefano Babic wrote:
> On 09/09/2011 09:36 AM, Wolfgang Denk wrote:

<snip>

> > 
> >> +# from comon directory
> >> +$(obj)memsize.c:
> >> +	@rm -f $@
> >> +	ln -s $(TOPDIR)/common/memsize.c $@
> > 
> > Can we not rather compile the file in the common directory instead?
> 
> This is only for nand_spl, not for u-boot. The nand_spl/board/Makefile
> has the list of files that must be compiled. Of course, the file was
> already compiled in common for u-boot.bin.
> 
> Not sure why this issue appears now. Rebuilding all ARM boards I see
> that hawkboard is broken, I have not bisect to check when it happened.

  Sorry for not having caught this earlier. I ran git bisect on this,
  and the commit "401bb30b6d replace CONFIG_PRELOADER with
  CONFIG_SPL_BUILD" seems to be causing the build break.

  The issue seems to be that the code in board/davinci/common/misc.c
  gets conditionally compiled based on definition of CONFIG_PRELOADER
  symbol, which was removed in this commit, and replaced by
  CONFIG_SPL_BUILD. I think we should correspondingly change this
  check in misc.c, so that it would not be required to compile in
  memsize.c. Let me know, and i will test this change and send out a
  patch. Thanks.

-sughosh

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
  2011-09-12 11:05     ` Sughosh Ganu
@ 2011-09-12 13:16       ` Stefano Babic
  0 siblings, 0 replies; 14+ messages in thread
From: Stefano Babic @ 2011-09-12 13:16 UTC (permalink / raw)
  To: u-boot

On 09/12/2011 01:05 PM, Sughosh Ganu wrote:
> hi Stefano,
> 
> On Fri Sep 09, 2011 at 11:04:14AM +0200, Stefano Babic wrote:
>> On 09/09/2011 09:36 AM, Wolfgang Denk wrote:
> 
> <snip>

Hi Sughosh,

> 
>   Sorry for not having caught this earlier. I ran git bisect on this,
>   and the commit "401bb30b6d replace CONFIG_PRELOADER with
>   CONFIG_SPL_BUILD" seems to be causing the build break.
> 
>   The issue seems to be that the code in board/davinci/common/misc.c
>   gets conditionally compiled based on definition of CONFIG_PRELOADER
>   symbol, which was removed in this commit, and replaced by
>   CONFIG_SPL_BUILD.

Yes, right.


> I think we should correspondingly change this
>   check in misc.c, so that it would not be required to compile in
>   memsize.c. Let me know, and i will test this change and send out a
>   patch. Thanks.

Agree. This is the right solution.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2011-09-12 13:16 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09  7:17 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Stefano Babic
2011-09-09  7:36 ` Wolfgang Denk
2011-09-09  9:04   ` Stefano Babic
2011-09-12 11:05     ` Sughosh Ganu
2011-09-12 13:16       ` Stefano Babic
2011-09-09  9:23 ` Stefano Babic
2011-09-09  9:36   ` Stefano Babic
2011-09-09  9:37 ` [U-Boot] [PATCH] ARM: hawkboard_nand: " Stefano Babic
2011-09-09 11:40   ` Wolfgang Denk
2011-09-09 12:40     ` Stefano Babic
2011-09-09 13:09 ` [U-Boot] [PATCH V2] " Stefano Babic
2011-09-10 14:13   ` Wolfgang Denk
2011-09-11 16:19     ` Albert ARIBAUD
2011-09-09 20:34 ` [U-Boot] [PATCH] ARM: hawkboard: " Paulraj, Sandeep

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox