From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds
Date: Mon, 12 Sep 2011 07:31:24 +0200 [thread overview]
Message-ID: <4E6D992C.6080904@aribaud.net> (raw)
In-Reply-To: <CA+T6QPm_zjZHoeY0bQaKr=MMHgLB_giteomgtWCxijiu85eUAQ@mail.gmail.com>
Hi Jason,
Le 11/09/2011 23:58, Jason Kridner a ?crit :
> On Sun, Sep 11, 2011 at 5:50 PM, Albert ARIBAUD
> <albert.u.boot@aribaud.net> wrote:
>> Le 08/09/2011 17:16, s-paulraj at ti.com a ?crit :
>>
>>> Jason Kridner (1):
>>> led: remove camel casing of led identifiers globally
>>
>> I just re-ran build tests, and this patch breaks a lot of boards because it
>> did not touch start.S files that refer to the LEDs. Since I've already
>> pulled it in,
>>
>> Jason, please provide a fix to this patch -- or I can revert it in
>> u-boot-arm/master.
>
> Against which commit should I provide the fix? Are you aware of any
> other identifiers that need to be fixed besides those in start.S?
> Would it be cleaner to revert and then have one patch to apply all of
> the identifier changes? (I'm going to get started assuming no and
> working against the head of your tree.)
I would have reverted if the patch had not already been part of an
applied pull request -- rolling back would be troublesome.
So your second patch is ok with me.
Amicalement,
--
Albert.
prev parent reply other threads:[~2011-09-12 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 15:16 [U-Boot] Please pull u-boot-ti/master s-paulraj at ti.com
2011-09-08 15:54 ` Albert ARIBAUD
2011-09-08 16:52 ` Paulraj, Sandeep
2011-09-08 17:20 ` Albert ARIBAUD
2011-09-08 15:58 ` Albert ARIBAUD
2011-09-11 21:50 ` [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds Albert ARIBAUD
2011-09-11 21:58 ` Jason Kridner
2011-09-12 5:31 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6D992C.6080904@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox