From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Mon, 12 Sep 2011 07:31:24 +0200 Subject: [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds In-Reply-To: References: <1315494977-11992-1-git-send-email-s-paulraj@ti.com> <4E6D2D1E.1040901@aribaud.net> Message-ID: <4E6D992C.6080904@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jason, Le 11/09/2011 23:58, Jason Kridner a ?crit : > On Sun, Sep 11, 2011 at 5:50 PM, Albert ARIBAUD > wrote: >> Le 08/09/2011 17:16, s-paulraj at ti.com a ?crit : >> >>> Jason Kridner (1): >>> led: remove camel casing of led identifiers globally >> >> I just re-ran build tests, and this patch breaks a lot of boards because it >> did not touch start.S files that refer to the LEDs. Since I've already >> pulled it in, >> >> Jason, please provide a fix to this patch -- or I can revert it in >> u-boot-arm/master. > > Against which commit should I provide the fix? Are you aware of any > other identifiers that need to be fixed besides those in start.S? > Would it be cleaner to revert and then have one patch to apply all of > the identifier changes? (I'm going to get started assuming no and > working against the head of your tree.) I would have reverted if the patch had not already been part of an applied pull request -- rolling back would be troublesome. So your second patch is ok with me. Amicalement, -- Albert.