* [U-Boot] Please pull u-boot-ti/master
@ 2011-09-08 15:16 s-paulraj at ti.com
2011-09-08 15:54 ` Albert ARIBAUD
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: s-paulraj at ti.com @ 2011-09-08 15:16 UTC (permalink / raw)
To: u-boot
Albert,
Please pull u-boot-ti/master.
I checked all the patches for checkpatch errors and fixed
all the warnings that i could. Some cannot be fixed.
Sanjeev's patches update thr GPIO for OMAP. The GPIO on OMAP
was causing issues which now seem to be fixed.
Regards,
Sandeep
The following changes since commit 63cf97e825b8d821e2d3d6d6c6604634ac24810a:
Sanjeev Premi (1):
omap3: beagle: Fix build warning
are available in the git repository at:
git://git.denx.de/u-boot-ti.git master
Aneesh V (4):
omap4: factor out common part from board config headers
omap4: make SDRAM init work for ES1.0 silicon
omap4: IO settings
omap4: fix pad configuration settings for SDP and Panda
Howard D. Gray (1):
ARMV7: OMAP3: Add 37xx ESx revision numbers.
Jason Kridner (1):
led: remove camel casing of led identifiers globally
Joel A Fernandes (1):
OMAP: Add function to get state of a GPIO output
Michael Jones (2):
ARMV7: OMAP: Write more than 1 byte at a time in i2c_write
ARMV7: OMAP: I2C driver: cosmetic: make checkpatch-compatible
Nagabhushana Netagunte (3):
da830: modify the U-Boot prompt string
da830: enable SPI flash boot mode
da830: modify the MEMTEST start and end address
Sandeep Paulraj (1):
OMAP3 Beagle: Minor config cleanup
Sanjeev Premi (3):
omap: gpio: Use generic API
omap: gpio: generic changes after changing API
omap: gpio: Adapt board files to use generic API
arch/arm/cpu/arm920t/ep93xx/led.c | 24 ++--
arch/arm/cpu/arm926ejs/at91/led.c | 12 +-
arch/arm/cpu/armv7/omap-common/gpio.c | 105 ++++++++++--
arch/arm/cpu/armv7/omap3/sys_info.c | 13 ++-
arch/arm/cpu/armv7/omap4/board.c | 62 +++++++
arch/arm/cpu/armv7/omap4/clocks.c | 5 +-
arch/arm/cpu/armv7/omap4/emif.c | 72 +-------
arch/arm/cpu/armv7/omap4/sdram_elpida.c | 24 ++--
arch/arm/include/asm/arch-omap3/omap3.h | 10 +
arch/arm/include/asm/arch-omap4/emif.h | 23 +---
arch/arm/include/asm/arch-omap4/omap4.h | 45 +++++-
arch/arm/include/asm/omap_gpio.h | 13 --
arch/arm/lib/board.c | 32 ++--
board/atmel/at91rm9200ek/led.c | 12 +-
board/cm_t35/leds.c | 10 +-
board/comelit/dig297/dig297.c | 12 +-
board/eukrea/cpu9260/led.c | 48 +++---
board/isee/igep0020/igep0020.c | 12 +-
board/logicpd/zoom2/debug_board.c | 10 +-
board/logicpd/zoom2/led.c | 66 ++++----
board/logicpd/zoom2/zoom2.c | 10 +-
board/overo/overo.c | 54 +++---
board/ti/beagle/beagle.c | 44 +++---
board/ti/beagle/led.c | 26 ++--
board/ti/evm/evm.c | 12 +-
board/ti/panda/panda_mux_data.h | 41 ++---
board/ti/sdp4430/sdp4430_mux_data.h | 9 +-
common/cmd_led.c | 8 +-
doc/README.omap3 | 20 +-
drivers/i2c/omap24xx_i2c.c | 241 +++++++++++++---------------
include/configs/da830evm.h | 17 +-
include/configs/omap3_beagle.h | 1 -
include/configs/omap4_common.h | 275 +++++++++++++++++++++++++++++++
include/configs/omap4_panda.h | 244 +--------------------------
include/configs/omap4_sdp4430.h | 245 +--------------------------
include/status_led.h | 32 ++--
36 files changed, 892 insertions(+), 997 deletions(-)
create mode 100644 include/configs/omap4_common.h
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] Please pull u-boot-ti/master
2011-09-08 15:16 [U-Boot] Please pull u-boot-ti/master s-paulraj at ti.com
@ 2011-09-08 15:54 ` Albert ARIBAUD
2011-09-08 16:52 ` Paulraj, Sandeep
2011-09-08 15:58 ` Albert ARIBAUD
2011-09-11 21:50 ` [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds Albert ARIBAUD
2 siblings, 1 reply; 8+ messages in thread
From: Albert ARIBAUD @ 2011-09-08 15:54 UTC (permalink / raw)
To: u-boot
Hi Sandeep,
Le 08/09/2011 17:16, s-paulraj at ti.com a ?crit :
> Albert,
>
> Please pull u-boot-ti/master.
> I checked all the patches for checkpatch errors and fixed
> all the warnings that i could. Some cannot be fixed.
> Sanjeev's patches update thr GPIO for OMAP. The GPIO on OMAP
> was causing issues which now seem to be fixed.
>
> Regards,
> Sandeep
>
> The following changes since commit 63cf97e825b8d821e2d3d6d6c6604634ac24810a:
> Sanjeev Premi (1):
> omap3: beagle: Fix build warning
>
> are available in the git repository at:
>
> git://git.denx.de/u-boot-ti.git master
>
> Aneesh V (4):
> omap4: factor out common part from board config headers
> omap4: make SDRAM init work for ES1.0 silicon
> omap4: IO settings
> omap4: fix pad configuration settings for SDP and Panda
>
> Howard D. Gray (1):
> ARMV7: OMAP3: Add 37xx ESx revision numbers.
>
> Jason Kridner (1):
> led: remove camel casing of led identifiers globally
>
> Joel A Fernandes (1):
> OMAP: Add function to get state of a GPIO output
>
> Michael Jones (2):
> ARMV7: OMAP: Write more than 1 byte at a time in i2c_write
> ARMV7: OMAP: I2C driver: cosmetic: make checkpatch-compatible
>
> Nagabhushana Netagunte (3):
> da830: modify the U-Boot prompt string
> da830: enable SPI flash boot mode
> da830: modify the MEMTEST start and end address
>
> Sandeep Paulraj (1):
> OMAP3 Beagle: Minor config cleanup
>
> Sanjeev Premi (3):
> omap: gpio: Use generic API
> omap: gpio: generic changes after changing API
> omap: gpio: Adapt board files to use generic API
>
> arch/arm/cpu/arm920t/ep93xx/led.c | 24 ++--
> arch/arm/cpu/arm926ejs/at91/led.c | 12 +-
> arch/arm/cpu/armv7/omap-common/gpio.c | 105 ++++++++++--
> arch/arm/cpu/armv7/omap3/sys_info.c | 13 ++-
> arch/arm/cpu/armv7/omap4/board.c | 62 +++++++
> arch/arm/cpu/armv7/omap4/clocks.c | 5 +-
> arch/arm/cpu/armv7/omap4/emif.c | 72 +-------
> arch/arm/cpu/armv7/omap4/sdram_elpida.c | 24 ++--
> arch/arm/include/asm/arch-omap3/omap3.h | 10 +
> arch/arm/include/asm/arch-omap4/emif.h | 23 +---
> arch/arm/include/asm/arch-omap4/omap4.h | 45 +++++-
> arch/arm/include/asm/omap_gpio.h | 13 --
> arch/arm/lib/board.c | 32 ++--
> board/atmel/at91rm9200ek/led.c | 12 +-
> board/cm_t35/leds.c | 10 +-
> board/comelit/dig297/dig297.c | 12 +-
> board/eukrea/cpu9260/led.c | 48 +++---
> board/isee/igep0020/igep0020.c | 12 +-
> board/logicpd/zoom2/debug_board.c | 10 +-
> board/logicpd/zoom2/led.c | 66 ++++----
> board/logicpd/zoom2/zoom2.c | 10 +-
> board/overo/overo.c | 54 +++---
> board/ti/beagle/beagle.c | 44 +++---
> board/ti/beagle/led.c | 26 ++--
> board/ti/evm/evm.c | 12 +-
> board/ti/panda/panda_mux_data.h | 41 ++---
> board/ti/sdp4430/sdp4430_mux_data.h | 9 +-
> common/cmd_led.c | 8 +-
> doc/README.omap3 | 20 +-
> drivers/i2c/omap24xx_i2c.c | 241 +++++++++++++---------------
> include/configs/da830evm.h | 17 +-
> include/configs/omap3_beagle.h | 1 -
> include/configs/omap4_common.h | 275 +++++++++++++++++++++++++++++++
> include/configs/omap4_panda.h | 244 +--------------------------
> include/configs/omap4_sdp4430.h | 245 +--------------------------
> include/status_led.h | 32 ++--
> 36 files changed, 892 insertions(+), 997 deletions(-)
> create mode 100644 include/configs/omap4_common.h
Rebasing and applying locally right now. What are these warnings that
cannot be eliminated?
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] Please pull u-boot-ti/master
2011-09-08 15:54 ` Albert ARIBAUD
@ 2011-09-08 16:52 ` Paulraj, Sandeep
2011-09-08 17:20 ` Albert ARIBAUD
0 siblings, 1 reply; 8+ messages in thread
From: Paulraj, Sandeep @ 2011-09-08 16:52 UTC (permalink / raw)
To: u-boot
>
> Hi Sandeep,
>
> Le 08/09/2011 17:16, s-paulraj at ti.com a ?crit :
> > Albert,
> >
> > Please pull u-boot-ti/master.
> > I checked all the patches for checkpatch errors and fixed
> > all the warnings that i could. Some cannot be fixed.
> > Sanjeev's patches update thr GPIO for OMAP. The GPIO on OMAP
> > was causing issues which now seem to be fixed.
> >
> > Regards,
> > Sandeep
> >
> > The following changes since commit
> 63cf97e825b8d821e2d3d6d6c6604634ac24810a:
> > Sanjeev Premi (1):
> > omap3: beagle: Fix build warning
> >
> > are available in the git repository at:
> >
> > git://git.denx.de/u-boot-ti.git master
> >
> > Aneesh V (4):
> > omap4: factor out common part from board config headers
> > omap4: make SDRAM init work for ES1.0 silicon
> > omap4: IO settings
> > omap4: fix pad configuration settings for SDP and Panda
> >
> > Howard D. Gray (1):
> > ARMV7: OMAP3: Add 37xx ESx revision numbers.
> >
> > Jason Kridner (1):
> > led: remove camel casing of led identifiers globally
> >
> > Joel A Fernandes (1):
> > OMAP: Add function to get state of a GPIO output
> >
> > Michael Jones (2):
> > ARMV7: OMAP: Write more than 1 byte at a time in i2c_write
> > ARMV7: OMAP: I2C driver: cosmetic: make checkpatch-compatible
> >
> > Nagabhushana Netagunte (3):
> > da830: modify the U-Boot prompt string
> > da830: enable SPI flash boot mode
> > da830: modify the MEMTEST start and end address
> >
> > Sandeep Paulraj (1):
> > OMAP3 Beagle: Minor config cleanup
> >
> > Sanjeev Premi (3):
> > omap: gpio: Use generic API
> > omap: gpio: generic changes after changing API
> > omap: gpio: Adapt board files to use generic API
> >
>
> Rebasing and applying locally right now. What are these warnings that
> cannot be eliminated?
u-boot does not have linux/gpio.h
checkpatch complains about this.
Regards,
Sandeep
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] Please pull u-boot-ti/master
2011-09-08 16:52 ` Paulraj, Sandeep
@ 2011-09-08 17:20 ` Albert ARIBAUD
0 siblings, 0 replies; 8+ messages in thread
From: Albert ARIBAUD @ 2011-09-08 17:20 UTC (permalink / raw)
To: u-boot
Hi again Sandeep,
Le 08/09/2011 18:52, Paulraj, Sandeep a ?crit :
>> What are these warnings that
>> cannot be eliminated?
>
> u-boot does not have linux/gpio.h
>
> checkpatch complains about this.
That brings us back to whether we can adapt checkpatch to our own needs.
Thanks for the clarification.
> Regards,
> Sandeep
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] Please pull u-boot-ti/master
2011-09-08 15:16 [U-Boot] Please pull u-boot-ti/master s-paulraj at ti.com
2011-09-08 15:54 ` Albert ARIBAUD
@ 2011-09-08 15:58 ` Albert ARIBAUD
2011-09-11 21:50 ` [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds Albert ARIBAUD
2 siblings, 0 replies; 8+ messages in thread
From: Albert ARIBAUD @ 2011-09-08 15:58 UTC (permalink / raw)
To: u-boot
Hi Sandeep,
Le 08/09/2011 17:16, s-paulraj at ti.com a ?crit :
> Albert,
>
> Please pull u-boot-ti/master.
> I checked all the patches for checkpatch errors and fixed
> all the warnings that i could. Some cannot be fixed.
> Sanjeev's patches update thr GPIO for OMAP. The GPIO on OMAP
> was causing issues which now seem to be fixed.
>
> Regards,
> Sandeep
>
> The following changes since commit 63cf97e825b8d821e2d3d6d6c6604634ac24810a:
> Sanjeev Premi (1):
> omap3: beagle: Fix build warning
>
> are available in the git repository at:
>
> git://git.denx.de/u-boot-ti.git master
>
> Aneesh V (4):
> omap4: factor out common part from board config headers
> omap4: make SDRAM init work for ES1.0 silicon
> omap4: IO settings
> omap4: fix pad configuration settings for SDP and Panda
>
> Howard D. Gray (1):
> ARMV7: OMAP3: Add 37xx ESx revision numbers.
>
> Jason Kridner (1):
> led: remove camel casing of led identifiers globally
>
> Joel A Fernandes (1):
> OMAP: Add function to get state of a GPIO output
>
> Michael Jones (2):
> ARMV7: OMAP: Write more than 1 byte at a time in i2c_write
> ARMV7: OMAP: I2C driver: cosmetic: make checkpatch-compatible
>
> Nagabhushana Netagunte (3):
> da830: modify the U-Boot prompt string
> da830: enable SPI flash boot mode
> da830: modify the MEMTEST start and end address
>
> Sandeep Paulraj (1):
> OMAP3 Beagle: Minor config cleanup
>
> Sanjeev Premi (3):
> omap: gpio: Use generic API
> omap: gpio: generic changes after changing API
> omap: gpio: Adapt board files to use generic API
>
> arch/arm/cpu/arm920t/ep93xx/led.c | 24 ++--
> arch/arm/cpu/arm926ejs/at91/led.c | 12 +-
> arch/arm/cpu/armv7/omap-common/gpio.c | 105 ++++++++++--
> arch/arm/cpu/armv7/omap3/sys_info.c | 13 ++-
> arch/arm/cpu/armv7/omap4/board.c | 62 +++++++
> arch/arm/cpu/armv7/omap4/clocks.c | 5 +-
> arch/arm/cpu/armv7/omap4/emif.c | 72 +-------
> arch/arm/cpu/armv7/omap4/sdram_elpida.c | 24 ++--
> arch/arm/include/asm/arch-omap3/omap3.h | 10 +
> arch/arm/include/asm/arch-omap4/emif.h | 23 +---
> arch/arm/include/asm/arch-omap4/omap4.h | 45 +++++-
> arch/arm/include/asm/omap_gpio.h | 13 --
> arch/arm/lib/board.c | 32 ++--
> board/atmel/at91rm9200ek/led.c | 12 +-
> board/cm_t35/leds.c | 10 +-
> board/comelit/dig297/dig297.c | 12 +-
> board/eukrea/cpu9260/led.c | 48 +++---
> board/isee/igep0020/igep0020.c | 12 +-
> board/logicpd/zoom2/debug_board.c | 10 +-
> board/logicpd/zoom2/led.c | 66 ++++----
> board/logicpd/zoom2/zoom2.c | 10 +-
> board/overo/overo.c | 54 +++---
> board/ti/beagle/beagle.c | 44 +++---
> board/ti/beagle/led.c | 26 ++--
> board/ti/evm/evm.c | 12 +-
> board/ti/panda/panda_mux_data.h | 41 ++---
> board/ti/sdp4430/sdp4430_mux_data.h | 9 +-
> common/cmd_led.c | 8 +-
> doc/README.omap3 | 20 +-
> drivers/i2c/omap24xx_i2c.c | 241 +++++++++++++---------------
> include/configs/da830evm.h | 17 +-
> include/configs/omap3_beagle.h | 1 -
> include/configs/omap4_common.h | 275 +++++++++++++++++++++++++++++++
> include/configs/omap4_panda.h | 244 +--------------------------
> include/configs/omap4_sdp4430.h | 245 +--------------------------
> include/status_led.h | 32 ++--
> 36 files changed, 892 insertions(+), 997 deletions(-)
> create mode 100644 include/configs/omap4_common.h
Applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds
2011-09-08 15:16 [U-Boot] Please pull u-boot-ti/master s-paulraj at ti.com
2011-09-08 15:54 ` Albert ARIBAUD
2011-09-08 15:58 ` Albert ARIBAUD
@ 2011-09-11 21:50 ` Albert ARIBAUD
2011-09-11 21:58 ` Jason Kridner
2 siblings, 1 reply; 8+ messages in thread
From: Albert ARIBAUD @ 2011-09-11 21:50 UTC (permalink / raw)
To: u-boot
Le 08/09/2011 17:16, s-paulraj at ti.com a ?crit :
> Jason Kridner (1):
> led: remove camel casing of led identifiers globally
I just re-ran build tests, and this patch breaks a lot of boards because
it did not touch start.S files that refer to the LEDs. Since I've
already pulled it in,
Jason, please provide a fix to this patch -- or I can revert it in
u-boot-arm/master.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds
2011-09-11 21:50 ` [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds Albert ARIBAUD
@ 2011-09-11 21:58 ` Jason Kridner
2011-09-12 5:31 ` Albert ARIBAUD
0 siblings, 1 reply; 8+ messages in thread
From: Jason Kridner @ 2011-09-11 21:58 UTC (permalink / raw)
To: u-boot
On Sun, Sep 11, 2011 at 5:50 PM, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:
> Le 08/09/2011 17:16, s-paulraj at ti.com a ?crit :
>
>> Jason Kridner (1):
>> ? ? ? led: remove camel casing of led identifiers globally
>
> I just re-ran build tests, and this patch breaks a lot of boards because it
> did not touch start.S files that refer to the LEDs. Since I've already
> pulled it in,
>
> Jason, please provide a fix to this patch -- or I can revert it in
> u-boot-arm/master.
Against which commit should I provide the fix? Are you aware of any
other identifiers that need to be fixed besides those in start.S?
Would it be cleaner to revert and then have one patch to apply all of
the identifier changes? (I'm going to get started assuming no and
working against the head of your tree.)
>
> Amicalement,
> --
> Albert.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds
2011-09-11 21:58 ` Jason Kridner
@ 2011-09-12 5:31 ` Albert ARIBAUD
0 siblings, 0 replies; 8+ messages in thread
From: Albert ARIBAUD @ 2011-09-12 5:31 UTC (permalink / raw)
To: u-boot
Hi Jason,
Le 11/09/2011 23:58, Jason Kridner a ?crit :
> On Sun, Sep 11, 2011 at 5:50 PM, Albert ARIBAUD
> <albert.u.boot@aribaud.net> wrote:
>> Le 08/09/2011 17:16, s-paulraj at ti.com a ?crit :
>>
>>> Jason Kridner (1):
>>> led: remove camel casing of led identifiers globally
>>
>> I just re-ran build tests, and this patch breaks a lot of boards because it
>> did not touch start.S files that refer to the LEDs. Since I've already
>> pulled it in,
>>
>> Jason, please provide a fix to this patch -- or I can revert it in
>> u-boot-arm/master.
>
> Against which commit should I provide the fix? Are you aware of any
> other identifiers that need to be fixed besides those in start.S?
> Would it be cleaner to revert and then have one patch to apply all of
> the identifier changes? (I'm going to get started assuming no and
> working against the head of your tree.)
I would have reverted if the patch had not already been part of an
applied pull request -- rolling back would be troublesome.
So your second patch is ok with me.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-09-12 5:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-08 15:16 [U-Boot] Please pull u-boot-ti/master s-paulraj at ti.com
2011-09-08 15:54 ` Albert ARIBAUD
2011-09-08 16:52 ` Paulraj, Sandeep
2011-09-08 17:20 ` Albert ARIBAUD
2011-09-08 15:58 ` Albert ARIBAUD
2011-09-11 21:50 ` [U-Boot] Please pull u-boot-ti/master -- breaks a lot of builds Albert ARIBAUD
2011-09-11 21:58 ` Jason Kridner
2011-09-12 5:31 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox