From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] led: remove camelcase in LED functions from assembly
Date: Mon, 12 Sep 2011 07:31:45 +0200 [thread overview]
Message-ID: <4E6D9941.6070902@aribaud.net> (raw)
In-Reply-To: <201109120004.41035.vapier@gentoo.org>
Hi Mike,
Le 12/09/2011 06:04, Mike Frysinger a ?crit :
> On Sunday, September 11, 2011 18:22:26 Jason Kridner wrote:
>> This was done with the following command-line:
>>
>> for file in `find . | grep '\.[chS]$'`;
>> do perl -i -pe 's/(green|yellow|red|blue)_LED_(on|off)/$1_led_$2/g' $file;
>> done
>
> one line:
> find . -name '*.[chS]' -exec \
> sed -ri 's/(green|yellow|red|blue)_LED_(on|off)/\1_led_\2/g'
>
>> --- a/arch/arm/cpu/arm1176/start.S
>> +++ b/arch/arm/cpu/arm1176/start.S
>>
>> bl coloured_LED_init
>> - bl red_LED_on
>> + bl red_led_on
>
> seems like you didnt fix coloured_LED_init
>
> also, i dont see you changing any of the .c files where these funcs are
> actually defined
> -mike
This patch is assumed to apply above the current git tip, where the
function definitions were already changed, and only .S files should be
fixed.
Running MAKEALL arm right now, just to make sure, then I will apply it
on top of u-boot-arm/master.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-09-12 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-11 22:22 [U-Boot] [PATCH] led: remove camelcase in LED functions from assembly Jason Kridner
2011-09-12 4:04 ` Mike Frysinger
2011-09-12 5:31 ` Albert ARIBAUD [this message]
2011-09-12 15:40 ` Albert ARIBAUD
2011-09-12 16:27 ` Mike Frysinger
2011-09-12 19:32 ` Albert ARIBAUD
2011-09-12 20:28 ` Mike Frysinger
2011-09-12 20:58 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6D9941.6070902@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox