From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Ungerer Date: Mon, 12 Sep 2011 22:39:44 +1000 Subject: [U-Boot] [PATCH] KS8695: convert KS8695 eth driver to CONFIG_MULTI_ETH In-Reply-To: <201109111515.07738.vapier@gentoo.org> References: <1315644034-10661-1-git-send-email-greg.ungerer@opengear.com> <201109111515.07738.vapier@gentoo.org> Message-ID: <4E6DFD90.1010607@opengear.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/12/2011 05:15 AM, Mike Frysinger wrote: > On Saturday, September 10, 2011 04:40:34 Greg Ungerer wrote: >> --- a/include/netdev.h >> +++ b/include/netdev.h >> >> +int ks8695_eth_initialize(bd_t *bis); > > so you say the func needs bd_t* ... > >> --- a/board/cm4008/cm4008.c >> +++ b/board/cm4008/cm4008.c >> --- a/board/cm41xx/cm41xx.c >> +++ b/board/cm41xx/cm41xx.c >> >> +int board_eth_init(bd_t *bis) >> +{ >> + return ks8695_eth_initialize(); >> +} > > but you dont pass it in the board funcs ... > >> --- a/drivers/net/ks8695eth.c >> +++ b/drivers/net/ks8695eth.c >> >> +int ks8695_eth_initialize(void) > > nor does the func itself even take it ... > > not sure how this compiles ? do none of these files include netdev.h ? if > they don't, i don't see how it compiles cleanly as that means you'd get > warnings about implicit func prototypes ... It compiled with a warning. Wolfgang fixed it in a follow-up patch. Regards Greg