From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 12 Sep 2011 15:16:22 +0200 Subject: [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl In-Reply-To: <20110912110527.GA19853@Hardy> References: <1315552622-27566-1-git-send-email-sbabic@denx.de> <20110909073638.2275F1408769@gemini.denx.de> <4E69D68E.4090504@denx.de> <20110912110527.GA19853@Hardy> Message-ID: <4E6E0626.2050103@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/12/2011 01:05 PM, Sughosh Ganu wrote: > hi Stefano, > > On Fri Sep 09, 2011 at 11:04:14AM +0200, Stefano Babic wrote: >> On 09/09/2011 09:36 AM, Wolfgang Denk wrote: > > Hi Sughosh, > > Sorry for not having caught this earlier. I ran git bisect on this, > and the commit "401bb30b6d replace CONFIG_PRELOADER with > CONFIG_SPL_BUILD" seems to be causing the build break. > > The issue seems to be that the code in board/davinci/common/misc.c > gets conditionally compiled based on definition of CONFIG_PRELOADER > symbol, which was removed in this commit, and replaced by > CONFIG_SPL_BUILD. Yes, right. > I think we should correspondingly change this > check in misc.c, so that it would not be required to compile in > memsize.c. Let me know, and i will test this change and send out a > patch. Thanks. Agree. This is the right solution. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================