public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Philip Balister <philip@balister.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip.
Date: Tue, 13 Sep 2011 09:54:44 -0400	[thread overview]
Message-ID: <4E6F60A4.2010906@balister.org> (raw)
In-Reply-To: <4E6CE3F6.4080206@balister.org>

On 09/11/2011 12:38 PM, Philip Balister wrote:
> I see I should have copied a maintainer on this patch. Which tree will
> this sort of path go upstream via? It seems like my choices are ARM of
> OMAP3.
>
> I've got a number of other patches that should go upstream that are
> Overo centric. In general, what route should they take upstream?

Ping? Any tips for getting patched committed would be helpful, I'm sure 
I'm doing something wrong.

Philip

>
> Philip
>
> On 09/09/2011 03:16 AM, Enric Balletb? i Serra wrote:
>> 2011/9/9 Philip Balister<philip@balister.org>:
>>> The existing timing does not quite meet the minimum requirements
>>> in the LAN9221 datasheet. The timing in this patch solves problems
>>> noticed on some parts. The patch also combines the CS configuration
>>> for the overo and igep0020 boards per request.
>>>
>>> Signed-off-by: Philip Balister<philip@opensdr.com>
>>> ---
>>> Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile
>>> tested only.
>>>
>>>    arch/arm/include/asm/arch-omap3/omap_gpmc.h |    9 +++++++++
>>>    board/isee/igep0020/igep0020.c              |    1 +
>>>    board/isee/igep0020/igep0020.h              |    9 ---------
>>>    board/overo/overo.c                         |    1 +
>>>    board/overo/overo.h                         |    9 ---------
>>>    5 files changed, 11 insertions(+), 18 deletions(-)
>>>
>>> diff --git a/arch/arm/include/asm/arch-omap3/omap_gpmc.h b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>>> index bd22bce..800e4ee 100644
>>> --- a/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>>> +++ b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>>> @@ -80,4 +80,13 @@
>>>    }
>>>    #endif
>>>
>>> +/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */
>>> +#define NET_LAN9221_GPMC_CONFIG1    0x00001000
>>> +#define NET_LAN9221_GPMC_CONFIG2    0x00060700
>>> +#define NET_LAN9221_GPMC_CONFIG3    0x00020201
>>> +#define NET_LAN9221_GPMC_CONFIG4    0x06000700
>>> +#define NET_LAN9221_GPMC_CONFIG5    0x0006090A
>>> +#define NET_LAN9221_GPMC_CONFIG6    0x87030000
>>> +#define NET_LAN9221_GPMC_CONFIG7    0x00000f6c
>>> +
>>>    #endif /* __ASM_ARCH_OMAP_GPMC_H */
>>> diff --git a/board/isee/igep0020/igep0020.c b/board/isee/igep0020/igep0020.c
>>> index 36cc924..a5210c9 100644
>>> --- a/board/isee/igep0020/igep0020.c
>>> +++ b/board/isee/igep0020/igep0020.c
>>> @@ -29,6 +29,7 @@
>>>    #include<asm/arch/mmc_host_def.h>
>>>    #include<asm/arch/mux.h>
>>>    #include<asm/arch/sys_proto.h>
>>> +#include<asm/arch/omap_gpmc.h>
>>>    #include<asm/mach-types.h>
>>>    #include "igep0020.h"
>>>
>>> diff --git a/board/isee/igep0020/igep0020.h b/board/isee/igep0020/igep0020.h
>>> index c08d758..3d6e15f 100644
>>> --- a/board/isee/igep0020/igep0020.h
>>> +++ b/board/isee/igep0020/igep0020.h
>>> @@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = {
>>>          "ONENAND",
>>>    };
>>>
>>> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>> -#define NET_LAN9221_GPMC_CONFIG1    0x00001000
>>> -#define NET_LAN9221_GPMC_CONFIG2    0x00080701
>>> -#define NET_LAN9221_GPMC_CONFIG3    0x00020201
>>> -#define NET_LAN9221_GPMC_CONFIG4    0x08030703
>>> -#define NET_LAN9221_GPMC_CONFIG5    0x00060908
>>> -#define NET_LAN9221_GPMC_CONFIG6    0x87030000
>>> -#define NET_LAN9221_GPMC_CONFIG7    0x00000f6c
>>> -
>>>    static void setup_net_chip(void);
>>>
>>>    /*
>>> diff --git a/board/overo/overo.c b/board/overo/overo.c
>>> index 4eafdb1..bcd7d62 100644
>>> --- a/board/overo/overo.c
>>> +++ b/board/overo/overo.c
>>> @@ -37,6 +37,7 @@
>>>    #include<asm/arch/mem.h>
>>>    #include<asm/arch/sys_proto.h>
>>>    #include<asm/arch/gpio.h>
>>> +#include<asm/arch/omap_gpmc.h>
>>>    #include<asm/mach-types.h>
>>>    #include "overo.h"
>>>
>>> diff --git a/board/overo/overo.h b/board/overo/overo.h
>>> index 68e1243..57f2457 100644
>>> --- a/board/overo/overo.h
>>> +++ b/board/overo/overo.h
>>> @@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {
>>>    #endif
>>>    };
>>>
>>> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>> -#define NET_LAN9221_GPMC_CONFIG1    0x00001000
>>> -#define NET_LAN9221_GPMC_CONFIG2    0x00080701
>>> -#define NET_LAN9221_GPMC_CONFIG3    0x00020201
>>> -#define NET_LAN9221_GPMC_CONFIG4    0x08030703
>>> -#define NET_LAN9221_GPMC_CONFIG5    0x00060908
>>> -#define NET_LAN9221_GPMC_CONFIG6    0x87030000
>>> -#define NET_LAN9221_GPMC_CONFIG7    0x00000f6c
>>> -
>>>    /*
>>>    * IEN  - Input Enable
>>>    * IDIS - Input Disable
>>> --
>>> 1.7.4.4
>>>
>>>
>>
>> Tested on igep0020 machine (aka IGEP v2). Thanks Philip
>>
>> Acked-by: Enric Balletbo i Serra<eballetbo@gmail.com>
>> Tested-by: Enric Balletbo i Serra<eballetbo@gmail.com>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2011-09-13 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 23:26 [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip Philip Balister
2011-09-09  7:16 ` Enric Balletbò i Serra
2011-09-11 16:38   ` Philip Balister
2011-09-13 13:54     ` Philip Balister [this message]
2011-09-13 20:27       ` Jason Kridner
2011-09-13 21:05         ` Paulraj, Sandeep
2011-09-13 21:04       ` Paulraj, Sandeep

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6F60A4.2010906@balister.org \
    --to=philip@balister.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox