* [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip.
@ 2011-09-08 23:26 Philip Balister
2011-09-09 7:16 ` Enric Balletbò i Serra
0 siblings, 1 reply; 7+ messages in thread
From: Philip Balister @ 2011-09-08 23:26 UTC (permalink / raw)
To: u-boot
The existing timing does not quite meet the minimum requirements
in the LAN9221 datasheet. The timing in this patch solves problems
noticed on some parts. The patch also combines the CS configuration
for the overo and igep0020 boards per request.
Signed-off-by: Philip Balister <philip@opensdr.com>
---
Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile
tested only.
arch/arm/include/asm/arch-omap3/omap_gpmc.h | 9 +++++++++
board/isee/igep0020/igep0020.c | 1 +
board/isee/igep0020/igep0020.h | 9 ---------
board/overo/overo.c | 1 +
board/overo/overo.h | 9 ---------
5 files changed, 11 insertions(+), 18 deletions(-)
diff --git a/arch/arm/include/asm/arch-omap3/omap_gpmc.h b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
index bd22bce..800e4ee 100644
--- a/arch/arm/include/asm/arch-omap3/omap_gpmc.h
+++ b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
@@ -80,4 +80,13 @@
}
#endif
+/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */
+#define NET_LAN9221_GPMC_CONFIG1 0x00001000
+#define NET_LAN9221_GPMC_CONFIG2 0x00060700
+#define NET_LAN9221_GPMC_CONFIG3 0x00020201
+#define NET_LAN9221_GPMC_CONFIG4 0x06000700
+#define NET_LAN9221_GPMC_CONFIG5 0x0006090A
+#define NET_LAN9221_GPMC_CONFIG6 0x87030000
+#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c
+
#endif /* __ASM_ARCH_OMAP_GPMC_H */
diff --git a/board/isee/igep0020/igep0020.c b/board/isee/igep0020/igep0020.c
index 36cc924..a5210c9 100644
--- a/board/isee/igep0020/igep0020.c
+++ b/board/isee/igep0020/igep0020.c
@@ -29,6 +29,7 @@
#include <asm/arch/mmc_host_def.h>
#include <asm/arch/mux.h>
#include <asm/arch/sys_proto.h>
+#include <asm/arch/omap_gpmc.h>
#include <asm/mach-types.h>
#include "igep0020.h"
diff --git a/board/isee/igep0020/igep0020.h b/board/isee/igep0020/igep0020.h
index c08d758..3d6e15f 100644
--- a/board/isee/igep0020/igep0020.h
+++ b/board/isee/igep0020/igep0020.h
@@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = {
"ONENAND",
};
-/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
-#define NET_LAN9221_GPMC_CONFIG1 0x00001000
-#define NET_LAN9221_GPMC_CONFIG2 0x00080701
-#define NET_LAN9221_GPMC_CONFIG3 0x00020201
-#define NET_LAN9221_GPMC_CONFIG4 0x08030703
-#define NET_LAN9221_GPMC_CONFIG5 0x00060908
-#define NET_LAN9221_GPMC_CONFIG6 0x87030000
-#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c
-
static void setup_net_chip(void);
/*
diff --git a/board/overo/overo.c b/board/overo/overo.c
index 4eafdb1..bcd7d62 100644
--- a/board/overo/overo.c
+++ b/board/overo/overo.c
@@ -37,6 +37,7 @@
#include <asm/arch/mem.h>
#include <asm/arch/sys_proto.h>
#include <asm/arch/gpio.h>
+#include <asm/arch/omap_gpmc.h>
#include <asm/mach-types.h>
#include "overo.h"
diff --git a/board/overo/overo.h b/board/overo/overo.h
index 68e1243..57f2457 100644
--- a/board/overo/overo.h
+++ b/board/overo/overo.h
@@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {
#endif
};
-/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
-#define NET_LAN9221_GPMC_CONFIG1 0x00001000
-#define NET_LAN9221_GPMC_CONFIG2 0x00080701
-#define NET_LAN9221_GPMC_CONFIG3 0x00020201
-#define NET_LAN9221_GPMC_CONFIG4 0x08030703
-#define NET_LAN9221_GPMC_CONFIG5 0x00060908
-#define NET_LAN9221_GPMC_CONFIG6 0x87030000
-#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c
-
/*
* IEN - Input Enable
* IDIS - Input Disable
--
1.7.4.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip.
2011-09-08 23:26 [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip Philip Balister
@ 2011-09-09 7:16 ` Enric Balletbò i Serra
2011-09-11 16:38 ` Philip Balister
0 siblings, 1 reply; 7+ messages in thread
From: Enric Balletbò i Serra @ 2011-09-09 7:16 UTC (permalink / raw)
To: u-boot
2011/9/9 Philip Balister <philip@balister.org>:
> The existing timing does not quite meet the minimum requirements
> in the LAN9221 datasheet. The timing in this patch solves problems
> noticed on some parts. The patch also combines the CS configuration
> for the overo and igep0020 boards per request.
>
> Signed-off-by: Philip Balister <philip@opensdr.com>
> ---
> Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile
> tested only.
>
> ?arch/arm/include/asm/arch-omap3/omap_gpmc.h | ? ?9 +++++++++
> ?board/isee/igep0020/igep0020.c ? ? ? ? ? ? ?| ? ?1 +
> ?board/isee/igep0020/igep0020.h ? ? ? ? ? ? ?| ? ?9 ---------
> ?board/overo/overo.c ? ? ? ? ? ? ? ? ? ? ? ? | ? ?1 +
> ?board/overo/overo.h ? ? ? ? ? ? ? ? ? ? ? ? | ? ?9 ---------
> ?5 files changed, 11 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-omap3/omap_gpmc.h b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
> index bd22bce..800e4ee 100644
> --- a/arch/arm/include/asm/arch-omap3/omap_gpmc.h
> +++ b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
> @@ -80,4 +80,13 @@
> ?}
> ?#endif
>
> +/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */
> +#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000
> +#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00060700
> +#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201
> +#define NET_LAN9221_GPMC_CONFIG4 ? ?0x06000700
> +#define NET_LAN9221_GPMC_CONFIG5 ? ?0x0006090A
> +#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000
> +#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c
> +
> ?#endif /* __ASM_ARCH_OMAP_GPMC_H */
> diff --git a/board/isee/igep0020/igep0020.c b/board/isee/igep0020/igep0020.c
> index 36cc924..a5210c9 100644
> --- a/board/isee/igep0020/igep0020.c
> +++ b/board/isee/igep0020/igep0020.c
> @@ -29,6 +29,7 @@
> ?#include <asm/arch/mmc_host_def.h>
> ?#include <asm/arch/mux.h>
> ?#include <asm/arch/sys_proto.h>
> +#include <asm/arch/omap_gpmc.h>
> ?#include <asm/mach-types.h>
> ?#include "igep0020.h"
>
> diff --git a/board/isee/igep0020/igep0020.h b/board/isee/igep0020/igep0020.h
> index c08d758..3d6e15f 100644
> --- a/board/isee/igep0020/igep0020.h
> +++ b/board/isee/igep0020/igep0020.h
> @@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = {
> ? ? ? ?"ONENAND",
> ?};
>
> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
> -#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000
> -#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00080701
> -#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201
> -#define NET_LAN9221_GPMC_CONFIG4 ? ?0x08030703
> -#define NET_LAN9221_GPMC_CONFIG5 ? ?0x00060908
> -#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000
> -#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c
> -
> ?static void setup_net_chip(void);
>
> ?/*
> diff --git a/board/overo/overo.c b/board/overo/overo.c
> index 4eafdb1..bcd7d62 100644
> --- a/board/overo/overo.c
> +++ b/board/overo/overo.c
> @@ -37,6 +37,7 @@
> ?#include <asm/arch/mem.h>
> ?#include <asm/arch/sys_proto.h>
> ?#include <asm/arch/gpio.h>
> +#include <asm/arch/omap_gpmc.h>
> ?#include <asm/mach-types.h>
> ?#include "overo.h"
>
> diff --git a/board/overo/overo.h b/board/overo/overo.h
> index 68e1243..57f2457 100644
> --- a/board/overo/overo.h
> +++ b/board/overo/overo.h
> @@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {
> ?#endif
> ?};
>
> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
> -#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000
> -#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00080701
> -#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201
> -#define NET_LAN9221_GPMC_CONFIG4 ? ?0x08030703
> -#define NET_LAN9221_GPMC_CONFIG5 ? ?0x00060908
> -#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000
> -#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c
> -
> ?/*
> ?* IEN ?- Input Enable
> ?* IDIS - Input Disable
> --
> 1.7.4.4
>
>
Tested on igep0020 machine (aka IGEP v2). Thanks Philip
Acked-by: Enric Balletbo i Serra <eballetbo@gmail.com>
Tested-by: Enric Balletbo i Serra <eballetbo@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip.
2011-09-09 7:16 ` Enric Balletbò i Serra
@ 2011-09-11 16:38 ` Philip Balister
2011-09-13 13:54 ` Philip Balister
0 siblings, 1 reply; 7+ messages in thread
From: Philip Balister @ 2011-09-11 16:38 UTC (permalink / raw)
To: u-boot
I see I should have copied a maintainer on this patch. Which tree will
this sort of path go upstream via? It seems like my choices are ARM of
OMAP3.
I've got a number of other patches that should go upstream that are
Overo centric. In general, what route should they take upstream?
Philip
On 09/09/2011 03:16 AM, Enric Balletb? i Serra wrote:
> 2011/9/9 Philip Balister<philip@balister.org>:
>> The existing timing does not quite meet the minimum requirements
>> in the LAN9221 datasheet. The timing in this patch solves problems
>> noticed on some parts. The patch also combines the CS configuration
>> for the overo and igep0020 boards per request.
>>
>> Signed-off-by: Philip Balister<philip@opensdr.com>
>> ---
>> Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile
>> tested only.
>>
>> arch/arm/include/asm/arch-omap3/omap_gpmc.h | 9 +++++++++
>> board/isee/igep0020/igep0020.c | 1 +
>> board/isee/igep0020/igep0020.h | 9 ---------
>> board/overo/overo.c | 1 +
>> board/overo/overo.h | 9 ---------
>> 5 files changed, 11 insertions(+), 18 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-omap3/omap_gpmc.h b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>> index bd22bce..800e4ee 100644
>> --- a/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>> +++ b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>> @@ -80,4 +80,13 @@
>> }
>> #endif
>>
>> +/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */
>> +#define NET_LAN9221_GPMC_CONFIG1 0x00001000
>> +#define NET_LAN9221_GPMC_CONFIG2 0x00060700
>> +#define NET_LAN9221_GPMC_CONFIG3 0x00020201
>> +#define NET_LAN9221_GPMC_CONFIG4 0x06000700
>> +#define NET_LAN9221_GPMC_CONFIG5 0x0006090A
>> +#define NET_LAN9221_GPMC_CONFIG6 0x87030000
>> +#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c
>> +
>> #endif /* __ASM_ARCH_OMAP_GPMC_H */
>> diff --git a/board/isee/igep0020/igep0020.c b/board/isee/igep0020/igep0020.c
>> index 36cc924..a5210c9 100644
>> --- a/board/isee/igep0020/igep0020.c
>> +++ b/board/isee/igep0020/igep0020.c
>> @@ -29,6 +29,7 @@
>> #include<asm/arch/mmc_host_def.h>
>> #include<asm/arch/mux.h>
>> #include<asm/arch/sys_proto.h>
>> +#include<asm/arch/omap_gpmc.h>
>> #include<asm/mach-types.h>
>> #include "igep0020.h"
>>
>> diff --git a/board/isee/igep0020/igep0020.h b/board/isee/igep0020/igep0020.h
>> index c08d758..3d6e15f 100644
>> --- a/board/isee/igep0020/igep0020.h
>> +++ b/board/isee/igep0020/igep0020.h
>> @@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = {
>> "ONENAND",
>> };
>>
>> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>> -#define NET_LAN9221_GPMC_CONFIG1 0x00001000
>> -#define NET_LAN9221_GPMC_CONFIG2 0x00080701
>> -#define NET_LAN9221_GPMC_CONFIG3 0x00020201
>> -#define NET_LAN9221_GPMC_CONFIG4 0x08030703
>> -#define NET_LAN9221_GPMC_CONFIG5 0x00060908
>> -#define NET_LAN9221_GPMC_CONFIG6 0x87030000
>> -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c
>> -
>> static void setup_net_chip(void);
>>
>> /*
>> diff --git a/board/overo/overo.c b/board/overo/overo.c
>> index 4eafdb1..bcd7d62 100644
>> --- a/board/overo/overo.c
>> +++ b/board/overo/overo.c
>> @@ -37,6 +37,7 @@
>> #include<asm/arch/mem.h>
>> #include<asm/arch/sys_proto.h>
>> #include<asm/arch/gpio.h>
>> +#include<asm/arch/omap_gpmc.h>
>> #include<asm/mach-types.h>
>> #include "overo.h"
>>
>> diff --git a/board/overo/overo.h b/board/overo/overo.h
>> index 68e1243..57f2457 100644
>> --- a/board/overo/overo.h
>> +++ b/board/overo/overo.h
>> @@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {
>> #endif
>> };
>>
>> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>> -#define NET_LAN9221_GPMC_CONFIG1 0x00001000
>> -#define NET_LAN9221_GPMC_CONFIG2 0x00080701
>> -#define NET_LAN9221_GPMC_CONFIG3 0x00020201
>> -#define NET_LAN9221_GPMC_CONFIG4 0x08030703
>> -#define NET_LAN9221_GPMC_CONFIG5 0x00060908
>> -#define NET_LAN9221_GPMC_CONFIG6 0x87030000
>> -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c
>> -
>> /*
>> * IEN - Input Enable
>> * IDIS - Input Disable
>> --
>> 1.7.4.4
>>
>>
>
> Tested on igep0020 machine (aka IGEP v2). Thanks Philip
>
> Acked-by: Enric Balletbo i Serra<eballetbo@gmail.com>
> Tested-by: Enric Balletbo i Serra<eballetbo@gmail.com>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip.
2011-09-11 16:38 ` Philip Balister
@ 2011-09-13 13:54 ` Philip Balister
2011-09-13 20:27 ` Jason Kridner
2011-09-13 21:04 ` Paulraj, Sandeep
0 siblings, 2 replies; 7+ messages in thread
From: Philip Balister @ 2011-09-13 13:54 UTC (permalink / raw)
To: u-boot
On 09/11/2011 12:38 PM, Philip Balister wrote:
> I see I should have copied a maintainer on this patch. Which tree will
> this sort of path go upstream via? It seems like my choices are ARM of
> OMAP3.
>
> I've got a number of other patches that should go upstream that are
> Overo centric. In general, what route should they take upstream?
Ping? Any tips for getting patched committed would be helpful, I'm sure
I'm doing something wrong.
Philip
>
> Philip
>
> On 09/09/2011 03:16 AM, Enric Balletb? i Serra wrote:
>> 2011/9/9 Philip Balister<philip@balister.org>:
>>> The existing timing does not quite meet the minimum requirements
>>> in the LAN9221 datasheet. The timing in this patch solves problems
>>> noticed on some parts. The patch also combines the CS configuration
>>> for the overo and igep0020 boards per request.
>>>
>>> Signed-off-by: Philip Balister<philip@opensdr.com>
>>> ---
>>> Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile
>>> tested only.
>>>
>>> arch/arm/include/asm/arch-omap3/omap_gpmc.h | 9 +++++++++
>>> board/isee/igep0020/igep0020.c | 1 +
>>> board/isee/igep0020/igep0020.h | 9 ---------
>>> board/overo/overo.c | 1 +
>>> board/overo/overo.h | 9 ---------
>>> 5 files changed, 11 insertions(+), 18 deletions(-)
>>>
>>> diff --git a/arch/arm/include/asm/arch-omap3/omap_gpmc.h b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>>> index bd22bce..800e4ee 100644
>>> --- a/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>>> +++ b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>>> @@ -80,4 +80,13 @@
>>> }
>>> #endif
>>>
>>> +/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */
>>> +#define NET_LAN9221_GPMC_CONFIG1 0x00001000
>>> +#define NET_LAN9221_GPMC_CONFIG2 0x00060700
>>> +#define NET_LAN9221_GPMC_CONFIG3 0x00020201
>>> +#define NET_LAN9221_GPMC_CONFIG4 0x06000700
>>> +#define NET_LAN9221_GPMC_CONFIG5 0x0006090A
>>> +#define NET_LAN9221_GPMC_CONFIG6 0x87030000
>>> +#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c
>>> +
>>> #endif /* __ASM_ARCH_OMAP_GPMC_H */
>>> diff --git a/board/isee/igep0020/igep0020.c b/board/isee/igep0020/igep0020.c
>>> index 36cc924..a5210c9 100644
>>> --- a/board/isee/igep0020/igep0020.c
>>> +++ b/board/isee/igep0020/igep0020.c
>>> @@ -29,6 +29,7 @@
>>> #include<asm/arch/mmc_host_def.h>
>>> #include<asm/arch/mux.h>
>>> #include<asm/arch/sys_proto.h>
>>> +#include<asm/arch/omap_gpmc.h>
>>> #include<asm/mach-types.h>
>>> #include "igep0020.h"
>>>
>>> diff --git a/board/isee/igep0020/igep0020.h b/board/isee/igep0020/igep0020.h
>>> index c08d758..3d6e15f 100644
>>> --- a/board/isee/igep0020/igep0020.h
>>> +++ b/board/isee/igep0020/igep0020.h
>>> @@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = {
>>> "ONENAND",
>>> };
>>>
>>> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>> -#define NET_LAN9221_GPMC_CONFIG1 0x00001000
>>> -#define NET_LAN9221_GPMC_CONFIG2 0x00080701
>>> -#define NET_LAN9221_GPMC_CONFIG3 0x00020201
>>> -#define NET_LAN9221_GPMC_CONFIG4 0x08030703
>>> -#define NET_LAN9221_GPMC_CONFIG5 0x00060908
>>> -#define NET_LAN9221_GPMC_CONFIG6 0x87030000
>>> -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c
>>> -
>>> static void setup_net_chip(void);
>>>
>>> /*
>>> diff --git a/board/overo/overo.c b/board/overo/overo.c
>>> index 4eafdb1..bcd7d62 100644
>>> --- a/board/overo/overo.c
>>> +++ b/board/overo/overo.c
>>> @@ -37,6 +37,7 @@
>>> #include<asm/arch/mem.h>
>>> #include<asm/arch/sys_proto.h>
>>> #include<asm/arch/gpio.h>
>>> +#include<asm/arch/omap_gpmc.h>
>>> #include<asm/mach-types.h>
>>> #include "overo.h"
>>>
>>> diff --git a/board/overo/overo.h b/board/overo/overo.h
>>> index 68e1243..57f2457 100644
>>> --- a/board/overo/overo.h
>>> +++ b/board/overo/overo.h
>>> @@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {
>>> #endif
>>> };
>>>
>>> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>> -#define NET_LAN9221_GPMC_CONFIG1 0x00001000
>>> -#define NET_LAN9221_GPMC_CONFIG2 0x00080701
>>> -#define NET_LAN9221_GPMC_CONFIG3 0x00020201
>>> -#define NET_LAN9221_GPMC_CONFIG4 0x08030703
>>> -#define NET_LAN9221_GPMC_CONFIG5 0x00060908
>>> -#define NET_LAN9221_GPMC_CONFIG6 0x87030000
>>> -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c
>>> -
>>> /*
>>> * IEN - Input Enable
>>> * IDIS - Input Disable
>>> --
>>> 1.7.4.4
>>>
>>>
>>
>> Tested on igep0020 machine (aka IGEP v2). Thanks Philip
>>
>> Acked-by: Enric Balletbo i Serra<eballetbo@gmail.com>
>> Tested-by: Enric Balletbo i Serra<eballetbo@gmail.com>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip.
2011-09-13 13:54 ` Philip Balister
@ 2011-09-13 20:27 ` Jason Kridner
2011-09-13 21:05 ` Paulraj, Sandeep
2011-09-13 21:04 ` Paulraj, Sandeep
1 sibling, 1 reply; 7+ messages in thread
From: Jason Kridner @ 2011-09-13 20:27 UTC (permalink / raw)
To: u-boot
On Tue, Sep 13, 2011 at 9:54 AM, Philip Balister <philip@balister.org> wrote:
> On 09/11/2011 12:38 PM, Philip Balister wrote:
>> I see I should have copied a maintainer on this patch. Which tree will
>> this sort of path go upstream via? It seems like my choices are ARM of
>> OMAP3.
>>
>> I've got a number of other patches that should go upstream that are
>> Overo centric. In general, what route should they take upstream?
>
> Ping? Any tips for getting patched committed would be helpful, I'm sure
> I'm doing something wrong.
Sandeep, is this a patch you can pull into either u-boot-ti/master or
u-boot-ti/next? I believe it is just a bug fix and might be suitable
to pull into the existing -rcX.
>
> Philip
>
>>
>> Philip
>>
>> On 09/09/2011 03:16 AM, Enric Balletb? i Serra wrote:
>>> 2011/9/9 Philip Balister<philip@balister.org>:
>>>> The existing timing does not quite meet the minimum requirements
>>>> in the LAN9221 datasheet. The timing in this patch solves problems
>>>> noticed on some parts. The patch also combines the CS configuration
>>>> for the overo and igep0020 boards per request.
>>>>
>>>> Signed-off-by: Philip Balister<philip@opensdr.com>
>>>> ---
>>>> Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile
>>>> tested only.
>>>>
>>>> ? ?arch/arm/include/asm/arch-omap3/omap_gpmc.h | ? ?9 +++++++++
>>>> ? ?board/isee/igep0020/igep0020.c ? ? ? ? ? ? ?| ? ?1 +
>>>> ? ?board/isee/igep0020/igep0020.h ? ? ? ? ? ? ?| ? ?9 ---------
>>>> ? ?board/overo/overo.c ? ? ? ? ? ? ? ? ? ? ? ? | ? ?1 +
>>>> ? ?board/overo/overo.h ? ? ? ? ? ? ? ? ? ? ? ? | ? ?9 ---------
>>>> ? ?5 files changed, 11 insertions(+), 18 deletions(-)
>>>>
>>>> diff --git a/arch/arm/include/asm/arch-omap3/omap_gpmc.h b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>>>> index bd22bce..800e4ee 100644
>>>> --- a/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>>>> +++ b/arch/arm/include/asm/arch-omap3/omap_gpmc.h
>>>> @@ -80,4 +80,13 @@
>>>> ? ?}
>>>> ? ?#endif
>>>>
>>>> +/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */
>>>> +#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000
>>>> +#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00060700
>>>> +#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201
>>>> +#define NET_LAN9221_GPMC_CONFIG4 ? ?0x06000700
>>>> +#define NET_LAN9221_GPMC_CONFIG5 ? ?0x0006090A
>>>> +#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000
>>>> +#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c
>>>> +
>>>> ? ?#endif /* __ASM_ARCH_OMAP_GPMC_H */
>>>> diff --git a/board/isee/igep0020/igep0020.c b/board/isee/igep0020/igep0020.c
>>>> index 36cc924..a5210c9 100644
>>>> --- a/board/isee/igep0020/igep0020.c
>>>> +++ b/board/isee/igep0020/igep0020.c
>>>> @@ -29,6 +29,7 @@
>>>> ? ?#include<asm/arch/mmc_host_def.h>
>>>> ? ?#include<asm/arch/mux.h>
>>>> ? ?#include<asm/arch/sys_proto.h>
>>>> +#include<asm/arch/omap_gpmc.h>
>>>> ? ?#include<asm/mach-types.h>
>>>> ? ?#include "igep0020.h"
>>>>
>>>> diff --git a/board/isee/igep0020/igep0020.h b/board/isee/igep0020/igep0020.h
>>>> index c08d758..3d6e15f 100644
>>>> --- a/board/isee/igep0020/igep0020.h
>>>> +++ b/board/isee/igep0020/igep0020.h
>>>> @@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = {
>>>> ? ? ? ? ?"ONENAND",
>>>> ? ?};
>>>>
>>>> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>>> -#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000
>>>> -#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00080701
>>>> -#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201
>>>> -#define NET_LAN9221_GPMC_CONFIG4 ? ?0x08030703
>>>> -#define NET_LAN9221_GPMC_CONFIG5 ? ?0x00060908
>>>> -#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000
>>>> -#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c
>>>> -
>>>> ? ?static void setup_net_chip(void);
>>>>
>>>> ? ?/*
>>>> diff --git a/board/overo/overo.c b/board/overo/overo.c
>>>> index 4eafdb1..bcd7d62 100644
>>>> --- a/board/overo/overo.c
>>>> +++ b/board/overo/overo.c
>>>> @@ -37,6 +37,7 @@
>>>> ? ?#include<asm/arch/mem.h>
>>>> ? ?#include<asm/arch/sys_proto.h>
>>>> ? ?#include<asm/arch/gpio.h>
>>>> +#include<asm/arch/omap_gpmc.h>
>>>> ? ?#include<asm/mach-types.h>
>>>> ? ?#include "overo.h"
>>>>
>>>> diff --git a/board/overo/overo.h b/board/overo/overo.h
>>>> index 68e1243..57f2457 100644
>>>> --- a/board/overo/overo.h
>>>> +++ b/board/overo/overo.h
>>>> @@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {
>>>> ? ?#endif
>>>> ? ?};
>>>>
>>>> -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>>> -#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000
>>>> -#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00080701
>>>> -#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201
>>>> -#define NET_LAN9221_GPMC_CONFIG4 ? ?0x08030703
>>>> -#define NET_LAN9221_GPMC_CONFIG5 ? ?0x00060908
>>>> -#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000
>>>> -#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c
>>>> -
>>>> ? ?/*
>>>> ? ?* IEN ?- Input Enable
>>>> ? ?* IDIS - Input Disable
>>>> --
>>>> 1.7.4.4
>>>>
>>>>
>>>
>>> Tested on igep0020 machine (aka IGEP v2). Thanks Philip
>>>
>>> Acked-by: Enric Balletbo i Serra<eballetbo@gmail.com>
>>> Tested-by: Enric Balletbo i Serra<eballetbo@gmail.com>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip.
2011-09-13 20:27 ` Jason Kridner
@ 2011-09-13 21:05 ` Paulraj, Sandeep
0 siblings, 0 replies; 7+ messages in thread
From: Paulraj, Sandeep @ 2011-09-13 21:05 UTC (permalink / raw)
To: u-boot
>
> On Tue, Sep 13, 2011 at 9:54 AM, Philip Balister <philip@balister.org>
> wrote:
> > On 09/11/2011 12:38 PM, Philip Balister wrote:
> >> I see I should have copied a maintainer on this patch. Which tree will
> >> this sort of path go upstream via? It seems like my choices are ARM of
> >> OMAP3.
> >>
> >> I've got a number of other patches that should go upstream that are
> >> Overo centric. In general, what route should they take upstream?
> >
> > Ping? Any tips for getting patched committed would be helpful, I'm sure
> > I'm doing something wrong.
>
> Sandeep, is this a patch you can pull into either u-boot-ti/master or
> u-boot-ti/next? I believe it is just a bug fix and might be suitable
> to pull into the existing -rcX.
>
u-boot-ti/next
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip.
2011-09-13 13:54 ` Philip Balister
2011-09-13 20:27 ` Jason Kridner
@ 2011-09-13 21:04 ` Paulraj, Sandeep
1 sibling, 0 replies; 7+ messages in thread
From: Paulraj, Sandeep @ 2011-09-13 21:04 UTC (permalink / raw)
To: u-boot
> On 09/11/2011 12:38 PM, Philip Balister wrote:
> > I see I should have copied a maintainer on this patch. Which tree will
> > this sort of path go upstream via? It seems like my choices are ARM of
> > OMAP3.
> >
> > I've got a number of other patches that should go upstream that are
> > Overo centric. In general, what route should they take upstream?
You can send them as soon as you are ready.
>
> Ping? Any tips for getting patched committed would be helpful, I'm sure
> I'm doing something wrong.
I'll apply it to u-boot-ti/next
I'll setup a next branch soon.
--Sandeep
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-09-13 21:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-08 23:26 [U-Boot] [PATCH v2] OMAP3: Overo: Update GPMC timing for ethernet chip Philip Balister
2011-09-09 7:16 ` Enric Balletbò i Serra
2011-09-11 16:38 ` Philip Balister
2011-09-13 13:54 ` Philip Balister
2011-09-13 20:27 ` Jason Kridner
2011-09-13 21:05 ` Paulraj, Sandeep
2011-09-13 21:04 ` Paulraj, Sandeep
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox