[U-Boot] [PATCH 2/9] powerpc/mpc85xxcds: Fix PCI speed

Tabi Timur-B04825
2011-09-13T19:20:49Z

On Tue, Sep 13, 2011 at 2:15 AM, Zhao Chenhui
<chenhui.zhao@freescale.com> wrote:

> @@ -222,8 +222,8 @@ int checkboard (void)
>
> ? ? ? ?printf("PCI1: %d bit, %s MHz, %s\n",
> ? ? ? ? ? ? ? ?(pci1_32) ? 32 : 64,
> - ? ? ? ? ? ? ? (pci1_speed == 33000000) ? "33" :
> - ? ? ? ? ? ? ? (pci1_speed == 66000000) ? "66" : "unknown",
> + ? ? ? ? ? ? ? (pci1_speed == 33333333) ? "33" :
> + ? ? ? ? ? ? ? (pci1_speed == 66666666) ? "66" : "unknown",

I already told you on the internal mailing list to fix this, because
it can never say "unknown". pci1_speed will always equal either
33333333 or 66666666. There is no way it can be set to anything else.

And Wolfgang is right -- this patch doesn't make any sense. Is the
problem that pci1_speed is wrong, or is the problem that it's
displaying the wrong value?

--
Timur Tabi
Linux kernel developer at Freescale